-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use proptypes from standalone package #1540
Comments
Given that we don't specify a Essentially - use I think the right move is to continue to be flexible with the |
@ajwhite that's true, but i want to highlight that the prop-types package work with react 14, 15 and 16: https://www.npmjs.com/package/prop-types |
Looks like this will warn in 15.6 and break in 16 |
@ajwhite why complicate things? Shouldn't we just move to |
Given @macrozone's findings -- sounds like we can move over without a problem on the compatibility fronts 👍 |
FWIW, I've considered moving glamorous to just use |
#1674 we've moved everything over. |
storybook-native still uses
import React, { Component, PropTypes } from 'react';
which does not work anymore in react 16.0.0.beta.x
it should use package prop-types
The text was updated successfully, but these errors were encountered: