[Bug]: incorrect check for peer dependencies in JsPackageManager.writePackageJson

[geertjansen]

Describe the bug

I think this line is incorrect:

storybook/code/lib/cli/src/js-package-manager/JsPackageManager.ts

Line 117 in 6028541

packageJsonToWrite.dependencies &&

and should be changed like this

  if (
-   packageJsonToWrite.dependencies &&
+   packageJsonToWrite.peerDependencies &&
    Object.keys(packageJsonToWrite.peerDependencies).length === 0
  ) {
    delete packageJsonToWrite.peerDependencies;
  }

To Reproduce

No response

System

No response

Additional context

No response

[shilman]

Thanks @geertjansen ! #22006

[shilman]

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.1.0-alpha.1 containing PR #22006 that references this issue. Upgrade today to the @future NPM tag to try it out!

npx sb@next upgrade --tag future

[shilman]

Jiminy cricket!! I just released https://github.com/storybookjs/storybook/releases/tag/v7.0.3 containing PR #22006 that references this issue. Upgrade today to the @latest NPM tag to try it out!

npx sb@latest upgrade