Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: @types/* package are sometimes declared in 'dependencies' instead of 'devDependencies' #24873

Open
xfournet opened this issue Nov 16, 2023 · 0 comments
Open

[Bug]: @types/* package are sometimes declared in 'dependencies' instead of 'devDependencies' #24873

xfournet opened this issue Nov 16, 2023 · 0 comments
Labels
bug dependencies good first issue help wanted sev:S3 typescript

Comments

@xfournet
Copy link

Describe the bug

It has two undesirable effects:

  • it leads to typescript errors, in my case caused by @types/node-fetch v2.6.9 being installed through @storybook/core-common that conflict with node-fetch v3 that now directly includes the typescript definition (@types/node-fetch no more necessary with v3)
  • it downloads & installs unnecessary packages (which is the purpose of correctly using devDependencies vs dependencies)

To Reproduce

No response

System

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug dependencies good first issue help wanted sev:S3 typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xfournet @shilman