Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mocked Actions with Storybook's test package #26158

Closed
jonniebigodes opened this issue Feb 22, 2024 · 1 comment · Fixed by #26208 or #26214
Closed

[Bug]: Mocked Actions with Storybook's test package #26158

jonniebigodes opened this issue Feb 22, 2024 · 1 comment · Fixed by #26208 or #26214

Comments

@jonniebigodes
Copy link
Contributor

Describe the bug

During some testing with Storybook's beta, it seems that the Angular examples we currently provide, specifically for the Button component, are not working as expected despite implementing the @storybook/test package in the component's story file. This may have been an oversight on our part, but it should be addressed to ensure that the examples are working as expected and the output is as intended, more even so with the upcoming release of Storybook 8, as this is a feature that will probably be used more often by our users and will be the default pattern to follow. Below is a small recording of the issue in question.

angular-beta-no-actions-fn-function.mp4

This issue also has a compound effect on the examples we currently provide, not only for this framework but also for the other supported ones, to which we should ensure that our examples apply this pattern as much as possible to guarantee that the user experience is consistent across all frameworks. However, if that is not possible based on the framework's limitations, we should at least adjust the documentation to reflect the limitation as how it's currently implemented it may lead to confusion and frustration for the user as the text and code examples provide an agnostic approach of how to implement the feature which may not be the case, leading to users reaching out to us via our support channels for help and clarification on the matter which is not ideal for the user or for us, when we could have avoided this by providing the correct information from the start.

cc @valentinpalkovic , @kasperpeulen @vanessayuenn

To Reproduce

  • Initialize an Angular project
  • Initialize Storybook
  • Open Storybook
  • Interact with the button to confirm this.

System

No response

Additional context

No response

@kasperpeulen
Copy link
Contributor

@valentinpalkovic and I found out that this issue only happens when compdocs is not setup well.

And that since this PR we broke compodocs for new angular projects:
#24531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment