You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
glob is a package that pulls in a lot of other dependencies, making it relatively big even if it's prebundled.
globby is slightly smaller, but ideally we shouldn't need to have both.
The e18e ecosystem has migrated a lot of packages to tinyglobby recently, and it seems like the preferred choice. I don't think fdir is enough for us, because we're explicitly exposing a glob API, but I could be wrong, let's investigate.
The most important thing to be aware of, is that we can't break the stories glob API: https://storybook.js.org/docs/api/main-config/main-config-stories
But there is a chance that is completely powered by picomatch behind the scenes, so it might not be relevant.
The high priorities are core and builder-vite, since the other packages are one-off CLIs used sparingly, so they are never installed. It's fine to migrate them too, but it should be separate work.
The text was updated successfully, but these errors were encountered:
One reason why globby was selected for the Save from Controls feature is that it respects .gitignore and doesn't involve ignored files in search results. We should keep that in mind when migrating away from it. cc @JReinhold
glob
is a package that pulls in a lot of other dependencies, making it relatively big even if it's prebundled.globby
is slightly smaller, but ideally we shouldn't need to have both.The e18e ecosystem has migrated a lot of packages to
tinyglobby
recently, and it seems like the preferred choice. I don't thinkfdir
is enough for us, because we're explicitly exposing a glob API, but I could be wrong, let's investigate.The most important thing to be aware of, is that we can't break the
stories
glob API: https://storybook.js.org/docs/api/main-config/main-config-storiesBut there is a chance that is completely powered by
picomatch
behind the scenes, so it might not be relevant.See:
Current dependents on
glob
:@storybook/builder-vite
@storybook/core
@storybook/cli
scripts
Current dependents on
globby
:@storybook/core
@storybook/cli
@storybook/codemod
The high priorities are
core
andbuilder-vite
, since the other packages are one-off CLIs used sparingly, so they are never installed. It's fine to migrate them too, but it should be separate work.The text was updated successfully, but these errors were encountered: