Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade distributed esbuild to match Vite 5's #29252

Closed
Tracked by #29038
JReinhold opened this issue Oct 1, 2024 · 0 comments · Fixed by #29254
Closed
Tracked by #29038

Upgrade distributed esbuild to match Vite 5's #29252

JReinhold opened this issue Oct 1, 2024 · 0 comments · Fixed by #29254
Assignees
@ndelangen

Comments

@JReinhold
Copy link
Contributor

JReinhold commented Oct 1, 2024 •
edited
Loading

Follow-up to #29082

If we align our version of esbuild with the one Vite 5 uses, it should allow it to be de-duplicated in all Vite-based projects.

https://github.com/vitejs/vite/blob/78e749ea9a42e7f82dbca37c26e8ab2a5e6e0c16/packages/vite/package.json#L88

This is a moving target, Vite could upgrade their version whenever they wanted to, but it's better than nothing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Core: Upgrade esbuild, broadening version range storybookjs/storybook
2 participants
@ndelangen @JReinhold