Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Source editing support #6642

Open
shilman opened this issue Apr 26, 2019 · 12 comments
Open

Addon-docs: Source editing support #6642

shilman opened this issue Apr 26, 2019 · 12 comments

Comments

@shilman
Copy link
Member

shilman commented Apr 26, 2019

Add editing support to #6641

Details TBD

@github-actions
Copy link
Contributor

github-actions bot commented Apr 26, 2019

Automention: Hey @elevatebart @igor-dv @JeroenReumkens, you've been tagged! Can you give a hand here?

@stale stale bot added the inactive label May 17, 2019
@shilman shilman removed the inactive label May 17, 2019
@libetl
Copy link
Member

libetl commented Jun 4, 2019

What do we want here ?

@libetl
Copy link
Member

libetl commented Jun 4, 2019

I can try to help

@shilman
Copy link
Member Author

shilman commented Jun 4, 2019

@libetl Haven't really spec'ed it out yet. Will definitely loop you in once this gets started.

There are some "lightweight" in-place code editors like https://github.com/FormidableLabs/react-live and I'd like to support this interaction. However, I'm unclear how this will integrate with the rest of the Storybook UI and also cross-framework.

More soon cc @elevatebart @JeroenReumkens

@stale stale bot added the inactive label Jul 3, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 3, 2019
@stale stale bot removed the inactive label Jul 3, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 3, 2019
@stale stale bot added the inactive label Jul 24, 2019
@kevinSuttle
Copy link
Contributor

kevinSuttle commented Jul 25, 2019

@stale stale bot removed the inactive label Jul 25, 2019
@storybookjs storybookjs deleted a comment from stale bot Jul 25, 2019
@shilman
Copy link
Member Author

shilman commented Jul 25, 2019

@kevinSuttle thanks for the link--that looks really useful. this is probably a 5.3 feature and still unclear how to fit it in in a cross-framework way!

@shilman shilman added the todo label Jul 25, 2019
@kevinSuttle
Copy link
Contributor

still unclear how to fit it in in a cross-framework way!

Definitely. That's not an easy task for sure. Thanks for your work on this!

@elevatebart
Copy link
Contributor

elevatebart commented Jul 25, 2019

The vue-inbrowser-compiler for VueJs is compiling vue components live and can be leveraged. For React there is buble.
It means definitely a lot of work to get cross framework compatibility with angular's typescript and ember functions.

@bodograumann
Copy link
Contributor

react-styleguidist / vue-styleguidist allow this. We are looking to use addon-docs instead of styleguidist. Would be great if editing was allowed. Maybe have a look at their solution.

@shilman
Copy link
Member Author

shilman commented Sep 26, 2019

@bodograumann we have the vue-styleguidist maintainer, @elevatebart, on our team now -- if anybody can figure it out, it's him!

@jonsalvas
Copy link

any updates on this? Really useful feature imo

@shilman shilman added this to the 8.x source addon milestone Jun 20, 2023
@shilman shilman removed the todo label Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants