Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use brandTitle with brandImage #6677

Closed
Hypnosphi opened this issue Apr 29, 2019 · 6 comments
Closed

Can't use brandTitle with brandImage #6677

Hypnosphi opened this issue Apr 29, 2019 · 6 comments

Comments

@Hypnosphi
Copy link
Member

Hypnosphi commented Apr 29, 2019

Describe the bug
Using brandImage overrides the effect of brandTitle

To Reproduce

addParameters({
  options: {
    theme: create({
      base: 'light',
      brandTitle: 'Title',
      brandImage: image,
    })
  }
});

Expected behavior
Both image and text are shown

https://jetbrains.github.io/ring-ui/develop-storybook

@brendonco
Copy link

how did you change the storybook logo?

@shilman
Copy link
Member

shilman commented May 9, 2019

@Hypnosphi This was a design decision. I believe if you override brandImage it should fill the whole space. Maybe @domyen or @ndelangen can give the rationale.

@Hypnosphi
Copy link
Member Author

This was a design decision

Can we reconsider it? Of course one can put a text in the SVG, but it complicates things a bit

@stale
Copy link

stale bot commented May 30, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 30, 2019
@shilman shilman modified the milestones: 5.0.x, 5.1.x Jun 5, 2019
@stale stale bot removed inactive labels Jun 5, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Jun 26, 2019
@stale
Copy link

stale bot commented Jul 26, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants