Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR (server side render) stories in the iframe #8009

Closed
treshugart opened this issue Sep 5, 2019 · 6 comments
Closed

SSR (server side render) stories in the iframe #8009

treshugart opened this issue Sep 5, 2019 · 6 comments

Comments

@treshugart
Copy link

Hey, everyone. First and foremost, Storybook is awesome and a joy to use, especially with the improvements coming in 5.2. Stoked!

I've looked, and it doesn't seem that Storybook server-side-renders the stories in the iframe. Searching only yielded a couple of results that are close to what I was looking for.

Looking at the iframe, it doesn't show any SSR content etc. Looking at the source also didn't reveal any clues, either.

I think it would be great as you could develop your stories and components with SSR in mind, and even run automated testing over them.

Do you have any thoughts regarding the support of SSR'ing stories?

FWIW, I'd be open to helping with this effort, but just wanted to gauge interest beforehand.

Thanks!

@shilman
Copy link
Member

shilman commented Sep 6, 2019

Would love to figure this out for docs

@stale
Copy link

stale bot commented Sep 27, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Sep 27, 2019
@YoungElPaso
Copy link

In this case is SSR synonymous with pre-rendering? I guess if you're developing w/ SSR in mind, that's not the case. But I think pre-rendering and SSR are related, and @shilman 's use case (docs) is the same one I'm going for.

@stale stale bot removed the inactive label Oct 11, 2019
@treshugart
Copy link
Author

Yeah, I think that would be sufficient. I think pre-rendering could cover a smoke test of SSR'able components.

@stale
Copy link

stale bot commented Nov 1, 2019

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label Nov 1, 2019
@stale
Copy link

stale bot commented Dec 2, 2019

Hey there, it's me again! I am going close this issue to help our maintainers focus on the current development roadmap instead. If the issue mentioned is still a concern, please open a new ticket and mention this old one. Cheers and thanks for using Storybook!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants