Bugfix story description first story #10171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as I have an exception when using yarn with npx i forced it to use npm instead by: ``` --use-npm ```
Update index.md
Fixed Angular button example story
Add BBC to list of examples
Fix CSF in MDX recipe
Typescript: Export IStory in `@storybook/angular`
Fix broken link to repo in empty knobs panel
Addon-docs: Fix TS false default value in prop table
L56 was missing an `=`, breaking `npm run storybook`
Added missing = in angular guide
Addon-docs: Revert breaking source indentation fix
Remove duplicate text
This may be intuitive enough to some, but it took me a minute to figure out so I think it'd be nice to have here.
Update Custom Body Documentation
Improve Typescript Configuration documentation page
Unlike react (`src`), Ember has its application source files inside `app` directory. I think for beginner it is easy to understand if we stick to ember folder naming conventions.
Change src to app path
patelvp
requested review from
aaronmcadam,
alexandrebodin,
alterx,
CodeByAlex,
dangreenisrael,
danielduan,
Gongreg,
igor-dv,
jbovenschen,
kazupon,
leonrodenburg,
thani-sh,
ndelangen,
renaudtertrais,
saponifi3d,
shilman,
stijnkoopal,
theinterned,
thomasbertet,
tmeasday,
usulpro and
z4o4z
as code owners
|
This is my First open source contribution. Not an expert in opening a PR for forked repositories. Probably my fork was outdate. Hence all these commits. Can someone help me with this? |
|
@patelvp please branch from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8093
What I did
expandedprop was set to false for Primary component which displays the first story. Hence the docs were not showing information as expected.expandedprop to true solves the issue.How to test