Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon/docs Fix first story docs not showing. #10180

Conversation

patelvp
Copy link

@patelvp patelvp commented Mar 21, 2020

Issue: #8093

What I did

  • expanded prop was set to false for Primary component which displays the first story. Hence the docs were not showing information as expected.
  • Setting expanded prop to true solves the issue.

How to test

  • Docs now appear for the first story.

@patelvp
Copy link
Author

patelvp commented Apr 3, 2020

@shilman Thanks for updating my branch!

@ndelangen
Copy link
Member

@patelvp could you resolve the merge conflicts?

@shilman is this good to merge?

@patelvp
Copy link
Author

patelvp commented Apr 17, 2020

@ndelangen Done!

@stale
Copy link

stale bot commented May 30, 2020

Hi everyone! Seems like there hasn't been much going on in this issue lately. If there are still questions, comments, or bugs, please feel free to continue the discussion. Unfortunately, we don't have time to get to every issue. We are always open to contributions so please send us a pull request if you would like to help. Inactive issues will be closed after 30 days. Thanks!

@stale stale bot added the inactive label May 30, 2020
@patelvp
Copy link
Author

patelvp commented May 30, 2020

Thoughts on this or should we close this?

@stale stale bot removed the inactive label May 30, 2020
@ndelangen
Copy link
Member

@shilman are you interested in merging this?

@shilman
Copy link
Member

shilman commented Jun 6, 2020

TBH I'm not sure. @domyen WDYT? It kind of breaks the design of the "primary" story, and users can always override this by hand using https://github.com/storybookjs/storybook/blob/next/addons/docs/docs/docspage.md#remixing-docspage-using-doc-blocks

@ndelangen
Copy link
Member

ndelangen commented Jun 8, 2020

I'd personally also vote to keep it as-is, IMHO

@domyen
Copy link
Member

domyen commented Jun 9, 2020

I think we should leave the default behavior as is. Folks can further customize behavior by passing their own custom docspages as @shilman mentioned.

@shilman
Copy link
Member

shilman commented Jun 9, 2020

OK, closing this then. Thanks for your patience @patelvp & see the workaround described above.

@sebastienbarre
Copy link

Love Storybook, but this is really a strange decision. As a new user, it took me a long time to figure out why my first story description was not showing, and find the corresponding workaround...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants