Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(knobs) Add caveat about date defaultValue #1719

Merged
merged 2 commits into from
Aug 23, 2017

Conversation

SpainTrain
Copy link
Contributor

Related to #804

Got bit by this and want to help others avoid :-)

@codecov
Copy link

codecov bot commented Aug 23, 2017

Codecov Report

Merging #1719 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1719   +/-   ##
=======================================
  Coverage   21.18%   21.18%           
=======================================
  Files         252      252           
  Lines        5694     5694           
  Branches      690      677   -13     
=======================================
  Hits         1206     1206           
- Misses       3956     3979   +23     
+ Partials      532      509   -23
Impacted Files Coverage Δ
...res__/update-addon-info/update-addon-info.input.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/layout.js 12.5% <0%> (ø) ⬆️
...rc/modules/ui/components/left_panel/text_filter.js 30.98% <0%> (ø) ⬆️
addons/info/src/components/markdown/htags.js 30% <0%> (ø) ⬆️
addons/knobs/src/components/PropForm.js 8.51% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/menu_item.js 19.14% <0%> (ø) ⬆️
...codemod/src/transforms/update-organisation-name.js 40.62% <0%> (ø) ⬆️
addons/knobs/src/components/types/Boolean.js 11.62% <0%> (ø) ⬆️
lib/ui/src/modules/api/configs/init_api.js 40.47% <0%> (ø) ⬆️
lib/components/src/navigation/menu_link.js 0% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6a690e...d98f5e8. Read the comment docs.

@ndelangen ndelangen merged commit 2b9d905 into storybookjs:master Aug 23, 2017
@ndelangen
Copy link
Member

Thank you @SpainTrain I'm sure this will help people!

@Hypnosphi
Copy link
Member

do not do ... date('Label')

This bothers me a bit. If the default behaviour is buggy, we should change it not forbid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants