Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build lib/store with tsup #19308

Merged
merged 2 commits into from
Oct 3, 2022
Merged

Build lib/store with tsup #19308

merged 2 commits into from
Oct 3, 2022

Conversation

javier-arango
Copy link
Contributor

@javier-arango javier-arango commented Sep 30, 2022 •
edited by IanVS
Loading

Issue:

Reference: #18732

What I did

Migrated lib-store to use the ts-up bundler.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@javier-arango javier-arango marked this pull request as ready for review September 30, 2022 17:00
@IanVS IanVS added the maintenance User-facing maintenance tasks label Sep 30, 2022
@IanVS IanVS requested a review from ndelangen September 30, 2022 18:03
@IanVS IanVS mentioned this pull request Oct 2, 2022
Closed
IanVS
IanVS approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and CI is 🟢.

@ndelangen ndelangen self-assigned this Oct 3, 2022
@ndelangen ndelangen merged commit 767830f into storybookjs:next Oct 3, 2022
@ndelangen
Copy link
Member

Thank you so much for the help @javier-arango ❤️

@javier-arango javier-arango deleted the feat/lib-store-tsup branch October 3, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javier-arango @ndelangen @IanVS