Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore (Documentation) Fix issue template to feature correct command #21976

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

jonniebigodes
Copy link
Contributor

@jonniebigodes jonniebigodes commented Apr 6, 2023

With this small pull request our issue template is updated to feature the correct command when providing the user's information.

What was done:

  • Updated the template to remove outdated sb binary usage in favour of the storybook one.

@vanessayuenn when you have a chance, can you take a look and follow up with me so we can merge this or continue to work on it to provide the most accurate information to our users?

Thanks in advance

EDIT: To prevent issues with merging just applied the patch label, although for situations as this one, it shouldn't be used

@jonniebigodes jonniebigodes self-assigned this Apr 6, 2023
@jonniebigodes jonniebigodes changed the title Chopre:Fix issue template to feature correct command Chore (Documentation) Fix issue template to feature correct command Apr 6, 2023
@jonniebigodes jonniebigodes added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 6, 2023
Copy link
Contributor

@vanessayuenn vanessayuenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonniebigodes
Copy link
Contributor Author

@vanessayuenn thanks for the speedy review. Appreciate it 🙏 ! Going to go ahead and merge it

@jonniebigodes jonniebigodes merged commit 53247e4 into next Apr 6, 2023
@jonniebigodes jonniebigodes deleted the chore_issue_template_tweak branch April 6, 2023 14:22
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 10, 2023
shilman pushed a commit that referenced this pull request Apr 10, 2023
Chore (Documentation) Fix issue template to feature correct command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants