-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3: Rollback v7 breaking change and keep reactive v6-compatible API #22229
Merged
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8a50224
Vue3: Try reactivity without invoking args as props
kasperpeulen b212c00
Fix chromatic errors
kasperpeulen 0b730f7
Update tests
kasperpeulen b853be5
Undo small change
kasperpeulen 947d895
Remove empty file
kasperpeulen 4453b60
Merge branch 'next' into kasper/vue3-reactivity-v6-compatible
kasperpeulen f5a64af
Merge branch 'next' into kasper/vue3-reactivity-v6-compatible
valentinpalkovic e9c784a
Merge branch 'next' into kasper/vue3-reactivity-v6-compatible
valentinpalkovic 77743b1
Remove createOrUpdateSlots as it is not needed anymore
kasperpeulen 8fd8a48
Update tests to reflect API
kasperpeulen 28c5416
Merge remote-tracking branch 'origin/kasper/vue3-reactivity-v6-compat…
kasperpeulen 7b92734
Merge branch 'next' into kasper/vue3-reactivity-v6-compatible
kasperpeulen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 0 additions & 33 deletions
33
...rs/vue3/template/stories_vue3-vite-default-ts/CustomRenderOptionsArgsFromProps.stories.ts
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chakAs3 I think I can remove the whole
slotsMap
. All the reactive test passes without it.My gut feeling is that line 25, fixes this.
Without it, the slots are basically static, and need to updated forcefully.
But now we fix the render function to be lazy, we don't need this code anymore.