Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Angular Prerelease sandbox #22379

Merged
merged 2 commits into from
May 4, 2023
Merged

Add Angular Prerelease sandbox #22379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d22a14
Add Angular Prerelease sandbox
valentinpalkovic May 3, 2023
a19905f
Skip flaky nextjs test
valentinpalkovic May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,30 +701,30 @@ workflows:
requires:
- build
- create-sandboxes:
parallelism: 31
parallelism: 32
requires:
- build
# - smoke-test-sandboxes: # disabled for now
# requires:
# - create-sandboxes
- build-sandboxes:
parallelism: 31
parallelism: 32
requires:
- create-sandboxes
- chromatic-sandboxes:
parallelism: 31
parallelism: 32
requires:
- build-sandboxes
- e2e-production:
parallelism: 31
parallelism: 32
requires:
- build-sandboxes
- e2e-dev:
parallelism: 4
requires:
- create-sandboxes
- test-runner-production:
parallelism: 31
parallelism: 32
requires:
- build-sandboxes
# TODO: reenable once we find out the source of flakyness
Expand Down
15 changes: 8 additions & 7 deletions code/e2e-tests/framework-nextjs.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,23 @@ test.describe('Next.js', () => {
sbPage = new SbPage(page);
});

test('should lazy load images by default', async () => {
// TODO: Test is flaky, investigate why
test.skip('should lazy load images by default', async () => {
await sbPage.navigateToStory('frameworks/nextjs/Image', 'lazy');

const img = sbPage.previewRoot().locator('img');

expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeFalsy();
});

// TODO: Test is very flaky, investigate why
// test('should eager load images when loading parameter is set to eager', async () => {
// await sbPage.navigateToStory('frameworks/nextjs/Image', 'eager');
// TODO: Test is flaky, investigate why
test.skip('should eager load images when loading parameter is set to eager', async () => {
await sbPage.navigateToStory('frameworks/nextjs/Image', 'eager');

// const img = sbPage.previewRoot().locator('img');
const img = sbPage.previewRoot().locator('img');

// expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeTruthy();
// });
expect(await img.evaluate<boolean, HTMLImageElement>((image) => image.complete)).toBeTruthy();
});
});

test.describe('next/navigation', () => {
Expand Down
4 changes: 1 addition & 3 deletions code/lib/cli/src/sandbox-templates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ const baseTemplates = {
builder: '@storybook/builder-webpack5',
},
skipTasks: ['e2e-tests-dev'],
inDevelopment: true,
},
'angular-cli/default-ts': {
name: 'Angular CLI (latest)',
Expand Down Expand Up @@ -473,8 +472,6 @@ export const allTemplates: Record<TemplateKey, Template> = {
export const ci: TemplateKey[] = ['cra/default-ts', 'react-vite/default-ts'];
export const pr: TemplateKey[] = [
...ci,
// TODO: add this after the sandbox is ready in the sandboxes repo
// 'angular-cli/prerelease',
'angular-cli/default-ts',
'vue3-vite/default-ts',
'vue-cli/vue2-default-js',
Expand All @@ -497,6 +494,7 @@ export const merged: TemplateKey[] = [
];
export const daily: TemplateKey[] = [
...merged,
'angular-cli/prerelease',
'cra/default-js',
'react-vite/default-js',
'vue3-vite/default-js',
Expand Down