Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: @storybook/source-loader migrated to strict TS #22420

Merged

Conversation

usrrname
Copy link
Contributor

@usrrname usrrname commented May 5, 2023

lint(tsconfig.json): migrate @storybook/source-loader to use strict TS

Part of #22176

What I did

Change compilerOptions.strict from false => true in tsconfig.json of @storybook/source-loader

How to test

  1. Ensure using node 16
  2. Run yarn task --task compile --no-link --start-from=install
  3. cd into src/code/libs/source-loader
  4. Run yarn check
  5. At root of project, run yarn test and ensure tests in source-loader pass.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen self-assigned this May 7, 2023
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit e98f14e into storybookjs:next May 7, 2023
@usrrname usrrname deleted the feat/22176-source-loader-strict-ts branch May 7, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants