Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: Broaden esbuild version range #26405

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Dependencies: Broaden esbuild version range #26405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/builders/builder-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@yarnpkg/esbuild-plugin-pnp": "^3.0.0-rc.10",
"browser-assert": "^1.2.1",
"ejs": "^3.1.8",
"esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is the same as ^0.18.0, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not according to https://jubianchi.github.io/semver-check/#/^0.18.0/0.19.0

Screenshot 2024-03-11 at 10 27 20
Screenshot 2024-03-11 at 10 27 27

Copy link
Contributor

@valentinpalkovic valentinpalkovic Mar 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot that versions that start with a 0 behave differently! Thanks for the clarification.

"esbuild-plugin-alias": "^0.2.1",
"express": "^4.17.3",
"fs-extra": "^11.1.0",
Expand Down
2 changes: 1 addition & 1 deletion code/lib/core-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
"@yarnpkg/libzip": "2.3.0",
"chalk": "^4.1.0",
"cross-spawn": "^7.0.3",
"esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0",
"esbuild-register": "^3.5.0",
"execa": "^5.0.0",
"file-system-cache": "2.3.0",
Expand Down
2 changes: 1 addition & 1 deletion code/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
"concurrently": "^5.3.0",
"cross-env": "^7.0.3",
"danger": "^11.2.6",
"esbuild": "^18.0.0 || ^19.0.0 || ^0.20.0",
"esbuild": "^0.18.0 || ^0.19.0 || ^0.20.0",
"esbuild-loader": "^3.0.0",
"esbuild-plugin-alias": "^0.2.1",
"eslint": "^8.56.0",
Expand Down
6 changes: 3 additions & 3 deletions code/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5476,7 +5476,7 @@ __metadata:
"@yarnpkg/esbuild-plugin-pnp": "npm:^3.0.0-rc.10"
browser-assert: "npm:^1.2.1"
ejs: "npm:^3.1.8"
esbuild: "npm:^18.0.0 || ^19.0.0 || ^0.20.0"
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0"
esbuild-plugin-alias: "npm:^0.2.1"
express: "npm:^4.17.3"
fs-extra: "npm:^11.1.0"
Expand Down Expand Up @@ -5742,7 +5742,7 @@ __metadata:
"@yarnpkg/libzip": "npm:2.3.0"
chalk: "npm:^4.1.0"
cross-spawn: "npm:^7.0.3"
esbuild: "npm:^18.0.0 || ^19.0.0 || ^0.20.0"
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0"
esbuild-register: "npm:^3.5.0"
execa: "npm:^5.0.0"
file-system-cache: "npm:2.3.0"
Expand Down Expand Up @@ -6679,7 +6679,7 @@ __metadata:
concurrently: "npm:^5.3.0"
cross-env: "npm:^7.0.3"
danger: "npm:^11.2.6"
esbuild: "npm:^18.0.0 || ^19.0.0 || ^0.20.0"
esbuild: "npm:^0.18.0 || ^0.19.0 || ^0.20.0"
esbuild-loader: "npm:^3.0.0"
esbuild-plugin-alias: "npm:^0.2.1"
eslint: "npm:^8.56.0"
Expand Down
Loading