Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular: Fix enableProdMode setting #28415

Merged
merged 7 commits into from
Jul 3, 2024
Merged

Angular: Fix enableProdMode setting #28415

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d221ef
Angular: Fix enableProdMode setting
valentinpalkovic Jul 1, 2024
ab26990
Update .gitignore
valentinpalkovic Jul 1, 2024
0642f3d
Update .gitignore
valentinpalkovic Jul 1, 2024
98c4ca6
Update gitignore
valentinpalkovic Jul 1, 2024
49a9617
Merge branch 'next' into valentin/fix-prod-mode
valentinpalkovic Jul 2, 2024
f02fc13
Merge branch 'next' into valentin/fix-prod-mode
valentinpalkovic Jul 2, 2024
a61d756
Merge branch 'next' into valentin/fix-prod-mode
valentinpalkovic Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions code/frameworks/angular/src/client/angular-beta/AbstractRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,17 +42,6 @@ export abstract class AbstractRenderer {
// Observable to change the properties dynamically without reloading angular module&component
protected storyProps$: Subject<ICollection | undefined>;

constructor() {
if (typeof NODE_ENV === 'string' && NODE_ENV !== 'development') {
try {
// platform should be set after enableProdMode()
enableProdMode();
} catch (e) {
console.debug(e);
}
}
}

protected abstract beforeFullRender(domNode?: HTMLElement): Promise<void>;

/**
Expand Down
Loading