Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix server-kitchen-sink #28842

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 8, 2024

What I did

I discovered that there were a few issues causing the example to not work, and fixed them.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B -1.94 0%
initSize 167 MB 167 MB 0 B -1.24 0%
diffSize 91.1 MB 91.1 MB 0 B -1.23 0%
buildSize 7.42 MB 7.42 MB 0 B -0.65 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -0.65 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B - 0%
buildSbPreviewSize 351 kB 351 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B -0.65 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -0.65 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 23s 6.2s -16s -735ms -2.24 🔰-266.1%
generateTime 20s 20.6s 593ms -0.52 2.9%
initTime 17.2s 17.6s 406ms -0.94 2.3%
buildTime 11.6s 10.6s -1s -2ms -2.5 🔰-9.4%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 10.6s 8.8s -1s -829ms 0.13 -20.7%
devManagerResponsive 6.2s 5.1s -1s -184ms -0.28 -23.2%
devManagerHeaderVisible 844ms 926ms 82ms 0.44 8.9%
devManagerIndexVisible 871ms 958ms 87ms 0.41 9.1%
devStoryVisibleUncached 1.4s 1.3s -127ms 0.32 -9.5%
devStoryVisible 885ms 979ms 94ms 0.37 9.6%
devAutodocsVisible 737ms 790ms 53ms 0.28 6.7%
devMDXVisible 827ms 839ms 12ms 0.94 1.4%
buildManagerHeaderVisible 897ms 909ms 12ms 1.14 1.3%
buildManagerIndexVisible 902ms 911ms 9ms 1.05 1%
buildStoryVisible 953ms 956ms 3ms 1.02 0.3%
buildAutodocsVisible 725ms 833ms 108ms 1.19 13%
buildMDXVisible 768ms 880ms 112ms 1.74 🔺12.7%

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen added build Internal-facing build tooling & test updates ci:normal labels Aug 8, 2024
@ndelangen ndelangen self-assigned this Aug 8, 2024
@ndelangen ndelangen changed the title Buikd: Fix server-kitchen-sink Build: Fix server-kitchen-sink Aug 8, 2024
Copy link

nx-cloud bot commented Aug 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 27f21c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit 7f138a4 into next Aug 8, 2024
61 of 69 checks passed
@ndelangen ndelangen deleted the norbert/fix-server-kitchen-sink branch August 8, 2024 18:33
@github-actions github-actions bot mentioned this pull request Aug 8, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant