Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: support unicode chars in story IDs #5964

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 8, 2019

Issue: #5876

What I did

  • Support unicode chars in story names
  • Remove punctuation only

From what I can tell on the Chinese/Korean internet, URLs typically contain unicode chars. They are escaped into long ugly strings when transcoded to ASCII, but people are used to it.

Technically this is a breaking change, but let's sneak it in since v5 has just been released and it's still kind of an edge case (since unicode chars are getting stripped currently)

How to test

yarn jest --testPathPattern id.test.js

Also:

cd examples/official-storybook
yarn storybook
open http://localhost:9011/?path=/story/core-unicode--%EB%B0%94%EB%B3%B4

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants