Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow browsing to a kind and get the first story #6720

Merged
merged 1 commit into from
May 6, 2019

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented May 6, 2019

Issue: #5925

What I did

Allow initial URLs of the form ?selectedKind=xyz (no selectedName) and ?path=/story/kind-sanitized--*, both of which take you to the first story for the kind

How to test

Try http://localhost:9011/?path=/story/ui-settings-shortcutsscreen--* and http://localhost:9011/?selectedKind=UI%7CSettings%2FShortcutsScreen in official storybook

  • Does this need an update to the documentation?

Maybe? I'm not sure

@vercel
Copy link

vercel bot commented May 6, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-5925-allow-linking-to-kind.storybook.now.sh

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This is really clean

@shilman shilman added this to the 5.1.0 milestone May 6, 2019
@shilman shilman merged commit 7ad8699 into next May 6, 2019
@shilman shilman deleted the 5925-allow-linking-to-kind branch May 6, 2019 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants