Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of writing add-on: replace 'withFoo' with the name of addon used in sample below 'withMyAddon' #9966

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

HerrickSpencer
Copy link
Contributor

Issue:
Documentation has inconsistant add-on name in sample vs description.

What I did

changed 'withFoo' to 'withMyAddon'

How to test

No test needed, simple text change in doc

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 26, 2020
@shilman shilman merged commit dd15920 into storybookjs:next Feb 26, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 14, 2020
shilman added a commit that referenced this pull request Mar 14, 2020
Documentation of writing add-on: replace 'withFoo' with the name of addon used in sample below 'withMyAddon'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants