Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add example for more meaningful static storybookUrl file path #9974

Merged
merged 1 commit into from
Feb 28, 2020
Merged

docs: add example for more meaningful static storybookUrl file path #9974

merged 1 commit into from
Feb 28, 2020

Conversation

JimmyLv
Copy link

@JimmyLv JimmyLv commented Feb 27, 2020

Issue:

What I did

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

shilman
shilman approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 28, 2020
@shilman shilman merged commit 3ebcd4a into storybookjs:master Feb 28, 2020
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 14, 2020
shilman added a commit that referenced this pull request Mar 14, 2020
@shilman
Merge pull request #9974 from JimmyLv/patch-3
9066d2b 
docs: add example for more meaningful static storybookUrl file path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JimmyLv @shilman