-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow IP Owner to Customize and Override Royalty Percentage in License Terms #269
Allow IP Owner to Customize and Override Royalty Percentage in License Terms #269
Conversation
7ea9d64
to
492528e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add an external view function that returns the real license terms after all the overrides are done - useful for external developers to show the real data.
Good point. will have another PR address it. |
Description
This PR introduces a new configuration item,
commercialRevShare
, in theLicenseConfig
to allow IP owners to customize and override the royalty percentage defined in the license terms. This enhancement enables derivative IPs to customize or change the royalty percentage for their further children/descendants.Key Changes
commercialRevShare
to theLicenseConfig
.commercialRevShare
read from the license terms with the customized value set in theLicenseConfig
.Objectives
commercialRevShare
to override the default value from the license terms when a child IP registers a derivative to the IP.Implementation Steps
commercialRevShare
field to theLicenseConfig
.commercialRevShare
from theLicenseConfig
if set, instead of the default value from the license terms.