Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow IP Owner to Customize and Override Royalty Percentage in License Terms #269

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

kingster-will
Copy link
Collaborator

Description

This PR introduces a new configuration item, commercialRevShare, in the LicenseConfig to allow IP owners to customize and override the royalty percentage defined in the license terms. This enhancement enables derivative IPs to customize or change the royalty percentage for their further children/descendants.

Key Changes

  • New Configuration Item: Added commercialRevShare to the LicenseConfig.
  • Override Mechanism: Implemented logic to override the commercialRevShare read from the license terms with the customized value set in the LicenseConfig.

Objectives

  • Customization: Allow IP owners to set a custom royalty percentage for each license.
  • Override Default: Enable the custom commercialRevShare to override the default value from the license terms when a child IP registers a derivative to the IP.

Implementation Steps

  1. Update LicenseConfig: Add the commercialRevShare field to the LicenseConfig.
  2. Override Logic: Implement the logic to use the custom commercialRevShare from the LicenseConfig if set, instead of the default value from the license terms.

@kingster-will kingster-will marked this pull request as ready for review October 15, 2024 04:36
Copy link
Member

@sebsadface sebsadface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link

@Spablob Spablob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add an external view function that returns the real license terms after all the overrides are done - useful for external developers to show the real data.

@kingster-will
Copy link
Collaborator Author

We may want to add an external view function that returns the real license terms after all the overrides are done - useful for external developers to show the real data.

Good point. will have another PR address it.

@kingster-will kingster-will merged commit a50c930 into storyprotocol:main Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants