Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: moved '--chain-id' flag from NodeCommand to TxCommand #638

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

srdtrk
Copy link
Contributor

@srdtrk srdtrk commented Jun 22, 2023

Description

This PR:

  • Moves --chain-id flag from all node commands to only tx commands because cosmos-sdk no longer supports the flag for queries by default.

closes: #637

@srdtrk srdtrk marked this pull request as ready for review June 22, 2023 10:12
@srdtrk srdtrk requested a review from a team as a code owner June 22, 2023 10:12
@srdtrk srdtrk requested a review from jtieri June 22, 2023 10:12
@boojamya boojamya added the dont_backport Do not backport to any other maintained branch label Jun 22, 2023
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!!

@jtieri jtieri merged commit c4a6352 into strangelove-ventures:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont_backport Do not backport to any other maintained branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Compatibility issues with SDK v0.47 queries
3 participants