More XML docs for memory pool classes.

Stratis.Bitcoin.IntegrationTests/FeeTests.cs

@@ -224,7 +224,7 @@ public void BlockPolicyEstimates()
 			{
 				Assert.True(mpool.EstimateSmartFee(i, out answerFound).FeePerK >= mpool.EstimateFee(i).FeePerK);
 				Assert.True(mpool.EstimateSmartFee(i, out answerFound).FeePerK >= mpool.GetMinFee(1).FeePerK);
-				Assert.True(mpool.EstimateSmartPriority(i, out answerFound) == BlockPolicyEstimator.INF_PRIORITY);
+				Assert.True(mpool.EstimateSmartPriority(i, out answerFound) == BlockPolicyEstimator.InfPriority);
 			}
 		}
     }

Stratis.Bitcoin.Tests/MemoryPool/MempoolPersistenceTest.cs

@@ -179,7 +179,7 @@ public void SaveStreamTest()
             }
 
             Assert.True(actualStreamLength > 0);
-            Assert.Equal(MempoolPersistence.MEMPOOL_DUMP_VERSION, actualVersion);
+            Assert.Equal(MempoolPersistence.MempoolDumpVersion, actualVersion);
             Assert.Equal(numTx, actualCount);
             Assert.Equal(loaded, toSave.ToArray());
         }

Stratis.Bitcoin/Features/MemoryPool/MempoolBehavior.cs

@@ -19,8 +19,6 @@ namespace Stratis.Bitcoin.Features.MemoryPool
     /// </summary>
     public class MempoolBehavior : NodeBehavior
     {
-        #region Fields
-
         /// <summary>
         /// Average delay between trickled inventory transmissions in seconds.
         /// Blocks and whitelisted receivers bypass this, outbound peers get half this delay. 
@@ -66,10 +64,6 @@ public class MempoolBehavior : NodeBehavior
         /// </summary>
         private readonly Dictionary<uint256, uint256> filterInventoryKnown;
 
-        #endregion
-
-        #region Constructors
-
         /// <summary>
         /// Constructs an instance of memory pool behavior.
         /// </summary>
@@ -124,10 +118,6 @@ public MempoolBehavior(
         {
         }
 
-        #endregion
-
-        #region Properties
-
         /// <summary>Time of last memory pool request in unix time.</summary>
         public long LastMempoolReq { get; private set; }
 
@@ -157,10 +147,6 @@ public bool CanSend
             }
         }
 
-        #endregion
-
-        #region NodeBehavior Overrides
-
         /// <inheritdoc />
         protected override void AttachCore()
         {
@@ -179,10 +165,6 @@ public override object Clone()
             return new MempoolBehavior(this.validator, this.manager, this.orphans, this.connectionManager, this.chainState, this.signals, this.logger);
         }
 
-        #endregion
-
-        #region Message Handlers
-
         /// <summary>
         /// Handler for processing incoming message from node.
         /// </summary>
@@ -247,10 +229,6 @@ private Task AttachedNode_MessageReceivedAsync(Node node, IncomingMessage messag
             return Task.CompletedTask;
         }
 
-        #endregion
-
-        #region Message Processing
-
         /// <summary>
         /// Send the memory pool payload to the attached node.
         /// Gets the transaction info from the memory pool and sends to the attached node.
@@ -445,10 +423,6 @@ private async Task SendAsTxInventory(Node node, IEnumerable<uint256> trxList)
             }
         }
 
-        #endregion
-
-        #region Operations
-
         /// <summary>
         /// Relays a transaction to the connected nodes.
         /// </summary>
@@ -516,7 +490,5 @@ public async Task SendTrickle()
             if (sends.Any())
                 await this.SendAsTxInventory(this.AttachedNode, sends);
         }
-
-        #endregion
     }
 }

Stratis.Bitcoin/Features/MemoryPool/MempoolFeature.cs

@@ -15,8 +15,6 @@ namespace Stratis.Bitcoin.Features.MemoryPool
     /// <seealso cref="https://github.com/bitcoin/bitcoin/blob/6dbcc74a0e0a7d45d20b03bb4eb41a027397a21d/src/txmempool.cpp"/>
     public class MempoolFeature : FullNodeFeature, IFeatureStats
     {
-        #region Fields
-
         /// <summary>Node notifications available to subscribe to.</summary>
         private readonly Signals.Signals signals;
 
@@ -35,10 +33,6 @@ public class MempoolFeature : FullNodeFeature, IFeatureStats
         /// <summary>Logger for the memory pool component.</summary>
         private readonly ILogger mempoolLogger;
 
-        #endregion
-
-        #region Constructors
-
         /// <summary>
         /// Constructs a memory pool feature.
         /// </summary>
@@ -74,10 +68,6 @@ public void AddFeatureStats(StringBuilder benchLogs)
             }
         }
 
-        #endregion
-
-        #region FullNodeFeature Overrides
-
         /// <inheritdoc />
         public override void Start()
         {
@@ -105,8 +95,6 @@ public override void Stop()
                 }
             }
         }
-
-        #endregion
     }
 
     /// <summary>

Stratis.Bitcoin/Features/MemoryPool/MempoolManager.cs

@@ -22,8 +22,6 @@ public class MempoolAsyncLock : AsyncLock
     /// </summary>
     public class MempoolManager
     {
-        #region Fields
-
         /// <summary>Memory pool persistence methods for loading and saving from storage.</summary>
         private IMempoolPersistence mempoolPersistence;
 
@@ -33,10 +31,6 @@ public class MempoolManager
         /// <summary>Transaction memory pool for managing transactions in the memory pool.</summary>
         private readonly TxMempool memPool;
 
-        #endregion
-
-        #region Constructors
-
         /// <summary>
         /// Constructs an instance of a memory pool manager object.
         /// </summary>
@@ -68,10 +62,6 @@ public MempoolManager(
             this.mempoolLogger = loggerFactory.CreateLogger(this.GetType().FullName);
         }
 
-        #endregion
-
-        #region Properties
-
         /// <summary>Lock for memory pool access.</summary>
         public MempoolAsyncLock MempoolLock { get; }
 
@@ -90,10 +80,6 @@ public MempoolManager(
         /// <summary>Access to memory pool validator performance counter.</summary>
         public MempoolPerformanceCounter PerformanceCounter => this.Validator.PerformanceCounter;
 
-        #endregion
-
-        #region Operations
-
         /// <summary>
         /// Gets the memory pool transactions.
         /// </summary>
@@ -249,7 +235,5 @@ public Task RemoveForBlock(Block block, int blockHeight)
                 this.Validator.PerformanceCounter.SetMempoolDynamicSize(this.memPool.DynamicMemoryUsage());
             });
         }
-
-        #endregion
     }
 }

Stratis.Bitcoin/Features/MemoryPool/MempoolOrphans.cs

@@ -17,8 +17,6 @@ namespace Stratis.Bitcoin.Features.MemoryPool
     /// </summary>
     public class MempoolOrphans
     {
-        #region Fields
-
         /// <summary>Expiration time for orphan transactions in seconds.</summary>
         private const long OrphanTxExpireTime = 20 * 60;
 
@@ -70,10 +68,6 @@ public class MempoolOrphans
         /// <summary>Location on chain when rejects are validated.</summary>
         private uint256 hashRecentRejectsChainTip;
 
-        #endregion
-
-        #region Constructors
-
         /// <summary>
         /// Constructs a memory pool orphan manager object.
         /// </summary>
@@ -116,20 +110,12 @@ public MempoolOrphans(
             this.mempoolLogger = loggerFactory.CreateLogger(this.GetType().FullName);
         }
 
-        #endregion
-
-        #region Properties
-
         /// <summary>A lock for managing asynchronous access to memory pool.</summary>
         public MempoolAsyncLock MempoolLock { get; }
 
         /// <summary>Memory pool validator for validating transactions.</summary>
         public IMempoolValidator Validator { get; } // public for testing
 
-        #endregion
-
-        #region Operations
-
         /// <summary>
         /// Object representing an orphan transaction information.
         /// When modifying, adapt the copy of this definition in tests/DoS_tests.
@@ -450,7 +436,5 @@ public Task EraseOrphansFor(ulong peer)
                 //return true;
             }).Unwrap();
         }
-
-        #endregion
     }
 }