Skip to content

Commit bdebfda

Browse files
committed
Add message to assert
1 parent 5ba24e5 commit bdebfda

File tree

3 files changed

+8
-6
lines changed
  • key-value
    • key-value-aio
    • key-value-sync/tests/code_gen/stores

3 files changed

+8
-6
lines changed

key-value/key-value-aio/src/key_value/aio/stores/dynamodb/store.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,13 @@ async def _get_managed_entry(self, *, key: str, collection: str) -> ManagedEntry
200200
if not json_value:
201201
return None
202202

203-
managed_entry = self._serialization_adapter.load_json(json_str=json_value)
203+
managed_entry: ManagedEntry = self._serialization_adapter.load_json(json_str=json_value)
204204

205-
ttl = item.get("ttl", {}).get("N")
206-
if ttl:
207-
managed_entry.expires_at = datetime.fromtimestamp(int(ttl), tz=timezone.utc)
205+
expires_at_epoch = item.get("ttl", {}).get("N")
206+
207+
# Our managed entry may carry a TTL, but the TTL in DynamoDB takes precedence.
208+
if expires_at_epoch:
209+
managed_entry.expires_at = datetime.fromtimestamp(int(expires_at_epoch), tz=timezone.utc)
208210

209211
return managed_entry
210212

key-value/key-value-aio/tests/stores/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -174,7 +174,7 @@ async def test_put_ttl_get_ttl(self, store: BaseStore):
174174

175175
assert value == {"test": "test"}
176176
assert ttl is not None
177-
assert ttl == IsFloat(approx=100)
177+
assert ttl == IsFloat(approx=100), f"TTL should be ~100, but is {ttl}"
178178

179179
async def test_negative_ttl(self, store: BaseStore):
180180
"""Tests that a negative ttl will return None when getting the key."""

key-value/key-value-sync/tests/code_gen/stores/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def test_put_ttl_get_ttl(self, store: BaseStore):
171171

172172
assert value == {"test": "test"}
173173
assert ttl is not None
174-
assert ttl == IsFloat(approx=100)
174+
assert ttl == IsFloat(approx=100), f"TTL should be ~100, but is {ttl}"
175175

176176
def test_negative_ttl(self, store: BaseStore):
177177
"""Tests that a negative ttl will return None when getting the key."""

0 commit comments

Comments
 (0)