Skip to content

Commit ea90880

Browse files
committed
Fix windows tests
1 parent 30aebe2 commit ea90880

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

key-value/key-value-aio/tests/stores/valkey/test_valkey.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
from typing_extensions import override
1010

1111
from key_value.aio.stores.base import BaseStore
12-
from key_value.aio.stores.valkey import ValkeyStore
1312
from tests.conftest import detect_on_windows, docker_container, should_skip_docker_tests
1413
from tests.stores.base import (
1514
BaseStoreTests,
@@ -35,10 +34,6 @@ class ValkeyFailedToStartError(Exception):
3534
pass
3635

3736

38-
def get_valkey_client_from_store(store: ValkeyStore):
39-
return store._connected_client # pyright: ignore[reportPrivateUsage, reportReturnType]
40-
41-
4237
@pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not running")
4338
@pytest.mark.skipif(detect_on_windows(), reason="Valkey is not supported on Windows")
4439
class TestValkeyStore(ContextManagerStoreTestMixin, BaseStoreTests):
@@ -93,9 +88,13 @@ async def store(self, setup_valkey: None):
9388
@override
9489
async def test_not_unbounded(self, store: BaseStore): ...
9590

96-
async def test_value_stored(self, store: ValkeyStore):
91+
async def test_value_stored(self, store: BaseStore):
92+
from key_value.aio.stores.valkey import ValkeyStore
93+
9794
await store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})
9895

96+
assert isinstance(store, ValkeyStore)
97+
9998
valkey_client = store._connected_client # pyright: ignore[reportPrivateUsage]
10099
assert valkey_client is not None
101100
value = await valkey_client.get(key="test::test_key")

key-value/key-value-sync/tests/code_gen/stores/valkey/test_valkey.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
from typing_extensions import override
1313

1414
from key_value.sync.code_gen.stores.base import BaseStore
15-
from key_value.sync.code_gen.stores.valkey import ValkeyStore
1615
from tests.code_gen.conftest import detect_on_windows, docker_container, should_skip_docker_tests
1716
from tests.code_gen.stores.base import BaseStoreTests, ContextManagerStoreTestMixin
1817

@@ -33,10 +32,6 @@ class ValkeyFailedToStartError(Exception):
3332
pass
3433

3534

36-
def get_valkey_client_from_store(store: ValkeyStore):
37-
return store._connected_client # pyright: ignore[reportPrivateUsage, reportReturnType]
38-
39-
4035
@pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not running")
4136
@pytest.mark.skipif(detect_on_windows(), reason="Valkey is not supported on Windows")
4237
class TestValkeyStore(ContextManagerStoreTestMixin, BaseStoreTests):
@@ -91,9 +86,13 @@ def store(self, setup_valkey: None):
9186
@override
9287
def test_not_unbounded(self, store: BaseStore): ...
9388

94-
def test_value_stored(self, store: ValkeyStore):
89+
def test_value_stored(self, store: BaseStore):
90+
from key_value.sync.code_gen.stores.valkey import ValkeyStore
91+
9592
store.put(collection="test", key="test_key", value={"name": "Alice", "age": 30})
9693

94+
assert isinstance(store, ValkeyStore)
95+
9796
valkey_client = store._connected_client # pyright: ignore[reportPrivateUsage]
9897
assert valkey_client is not None
9998
value = valkey_client.get(key="test::test_key")

0 commit comments

Comments
 (0)