Skip to content

Commit

Permalink
adjust changeset descriptions (fixes #4187)
Browse files Browse the repository at this point in the history
- use plural
- avoid "add", instead use "specify", "determine" or "survey". The latter specifically if the quest could lead to the whole object being tagged differently now
  • Loading branch information
westnordost committed Jul 13, 2022
1 parent 3bdfe67 commit 7c97885
Show file tree
Hide file tree
Showing 136 changed files with 137 additions and 136 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class SidewalkOverlay : Overlay {

override val title = R.string.overlay_sidewalk
override val icon = R.drawable.ic_quest_sidewalk
override val changesetComment = "Add whether there are sidewalks"
override val changesetComment = "Specify whether roads have sidewalks"
override val wikiLink: String = "Key:sidewalk"
override val achievements = listOf(PEDESTRIAN)
override val hidesQuestTypes = setOf(AddSidewalk::class.simpleName!!)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class WayLitOverlay : Overlay {

override val title = R.string.overlay_lit
override val icon = R.drawable.ic_quest_lantern
override val changesetComment = "Add whether way is lit"
override val changesetComment = "Specify whether ways are lit"
override val wikiLink: String = "Key:lit"
override val achievements = listOf(PEDESTRIAN)
override val hidesQuestTypes = setOf(AddWayLit::class.simpleName!!)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class AddAcceptsCards : OsmFilterQuestType<CardAcceptance>() {
and !brand and !wikipedia:brand and !wikidata:brand
and (!seasonal or seasonal = no)
"""
override val changesetComment = "Add whether cards are accepted"
override val changesetComment = "Survey whether payment with cards is accepted"
override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside
override val wikiLink = "Key:payment"
override val icon = R.drawable.ic_quest_card
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class AddAcceptsCash : OsmFilterQuestType<Boolean>() {
"""
}

override val changesetComment = "Add whether this place accepts cash as payment"
override val changesetComment = "Survey whether payment with cash is accepted"
override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside
override val wikiLink = "Key:payment"
override val icon = R.drawable.ic_quest_cash
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AddAddressStreet : OsmElementQuestType<AddressStreetAnswer> {
addr:street and addr:interpolation
""".toElementFilterExpression() }

override val changesetComment = "Add street/place names to address"
override val changesetComment = "Specify street/place names to addresses"
override val icon = R.drawable.ic_quest_housenumber_street
override val wikiLink = "Key:addr"
// In Japan, housenumbers usually have block numbers, not streets
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class AddAirConditioning : OsmFilterQuestType<Boolean>() {
and takeaway != only
and !air_conditioning
"""
override val changesetComment = "Add air conditioning"
override val changesetComment = "Survey availability of air conditioning"
override val wikiLink = "Key:air_conditioning"
override val icon = R.drawable.ic_quest_snow_poi
override val isReplaceShopEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AddAirCompressor : OsmFilterQuestType<Boolean>() {
and access !~ private|no
"""

override val changesetComment = "Add whether air compressor is available"
override val changesetComment = "Survey availability of air compressors"
override val wikiLink = "Key:compressed_air"
override val icon = R.drawable.ic_quest_car_air_compressor
override val achievements = listOf(CAR, BICYCLIST)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class AddBicyclePump : OsmFilterQuestType<Boolean>() {
)
and access !~ private|no|customers
"""
override val changesetComment = "Add whether bicycle pump is available"
override val changesetComment = "Survey whether bicycle pumps are available"
override val wikiLink = "Key:service:bicycle:pump"
override val icon = R.drawable.ic_quest_bicycle_pump
override val achievements = listOf(BICYCLIST)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import de.westnordost.streetcomplete.osm.Tags
class AddAtmOperator : OsmFilterQuestType<String>() {

override val elementFilter = "nodes with amenity = atm and !operator and !name and !brand"
override val changesetComment = "Add ATM operator"
override val changesetComment = "Specify ATM operator"
override val wikiLink = "Tag:amenity=atm"
override val icon = R.drawable.ic_quest_money
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AddBabyChangingTable : OsmFilterQuestType<Boolean>() {
)
and !diaper and !changing_table
"""
override val changesetComment = "Add baby changing table"
override val changesetComment = "Survey availability of baby changing tables"
override val wikiLink = "Key:changing_table"
override val icon = R.drawable.ic_quest_baby
override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import de.westnordost.streetcomplete.osm.Tags
class AddBicycleBarrierType : OsmFilterQuestType<BicycleBarrierTypeAnswer>() {

override val elementFilter = "nodes with barrier = cycle_barrier and !cycle_barrier"
override val changesetComment = "Add specific cycle barrier type"
override val changesetComment = "Specify cycle barrier types"
override val wikiLink = "Key:cycle_barrier"
override val icon = R.drawable.ic_quest_no_bicycles
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class AddBarrierOnPath : OsmElementQuestType<BarrierType> {
and (access !~ private|no or (foot and foot !~ private|no))
""".toElementFilterExpression() }

override val changesetComment = "Add how path and barrier intersect"
override val changesetComment = "Specify how paths and barriers intersect"
override val wikiLink = "Key:barrier"
override val icon = R.drawable.ic_quest_barrier_on_path
override val achievements = listOf(PEDESTRIAN, WHEELCHAIR, OUTDOORS)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AddBarrierOnRoad : OsmElementQuestType<BarrierType> {
and (access !~ private|no or (foot and foot !~ private|no))
""".toElementFilterExpression() }

override val changesetComment = "Add how road and barrier intersect"
override val changesetComment = "Specify how roads and barriers intersect"
override val wikiLink = "Key:barrier"
override val icon = R.drawable.ic_quest_barrier_on_road
override val achievements = listOf(CAR)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AddBarrierType : OsmFilterQuestType<BarrierType>() {
and !aeroway
and !railway
"""
override val changesetComment = "Add specific barrier type on a point"
override val changesetComment = "Specify type of barriers"
override val wikiLink = "Key:barrier"
override val icon = R.drawable.ic_quest_barrier
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class AddStileType : OsmElementQuestType<StileTypeAnswer> {
override fun isApplicableTo(element: Element): Boolean? =
if (!stileNodeFilter.matches(element)) false else null

override val changesetComment = "Add specific stile type"
override val changesetComment = "Specify stile types"
override val wikiLink = "Key:stile"
override val icon = R.drawable.ic_quest_no_cow
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class AddBenchBackrest : OsmFilterQuestType<BenchBackrestAnswer>() {
and !bench:type
and (!seasonal or seasonal = no)
"""
override val changesetComment = "Add backrest information to benches"
override val changesetComment = "Survey whether benches have backrests"
override val wikiLink = "Tag:amenity=bench"
override val icon = R.drawable.ic_quest_bench_poi
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AddBikeParkingCapacity : OsmFilterQuestType<Int>() {
removing a few of them is minor work
*/

override val changesetComment = "Add bicycle parking capacities"
override val changesetComment = "Specify bicycle parking capacities"
override val wikiLink = "Tag:amenity=bicycle_parking"
override val icon = R.drawable.ic_quest_bicycle_parking_capacity
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class AddBikeParkingCover : OsmFilterQuestType<Boolean>() {
and !covered
and bicycle_parking !~ shed|lockers|building
"""
override val changesetComment = "Add bicycle parkings cover"
override val changesetComment = "Specify bicycle parkings covers"
override val wikiLink = "Tag:amenity=bicycle_parking"
override val icon = R.drawable.ic_quest_bicycle_parking_cover
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class AddBikeParkingType : OsmFilterQuestType<BikeParkingType>() {
and access !~ private|no
and !bicycle_parking
"""
override val changesetComment = "Add bicycle parking type"
override val changesetComment = "Specify bicycle parking types"
override val wikiLink = "Key:bicycle_parking"
override val icon = R.drawable.ic_quest_bicycle_parking
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AddBikeRentalCapacity : OsmFilterQuestType<Int>() {
and (!capacity or capacity older today -6 years)
"""

override val changesetComment = "Add bicycle rental capacities"
override val changesetComment = "Specify bicycle rental capacities"
override val wikiLink = "Tag:amenity=bicycle_rental"
override val icon = R.drawable.ic_quest_bicycle_rental_capacity
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class AddBikeRentalType : OsmFilterQuestType<BikeRentalTypeAnswer>() {
and (!bicycle_rental or bicycle_rental = yes)
and !shop
"""
override val changesetComment = "Add bicycle rental type"
override val changesetComment = "Specify bicycle rental types"
override val wikiLink = "Key:bicycle_rental"
override val icon = R.drawable.ic_quest_bicycle_rental
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class AddBikeRepairAvailability : OsmFilterQuestType<Boolean>() {
and access !~ private|no
"""

override val changesetComment = "Add whether bicycle shop offers repair"
override val changesetComment = "Specify whether bicycle shops offer repairs"
override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside
override val wikiLink = "Key:service:bicycle:repair"
override val icon = R.drawable.ic_quest_bicycle_repair
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,11 @@ class AddSecondHandBicycleAvailability : OsmFilterQuestType<SecondHandBicycleAva
and access !~ private|no
"""

override val changesetComment = "Add whether bicycle shop sells second-hand bicycles"
override val changesetComment = "Survey whether bicycle shop sells second-hand bicycles"
override val defaultDisabledMessage = R.string.default_disabled_msg_go_inside
override val wikiLink = "Tag:service:bicycle:second_hand"
override val icon = R.drawable.ic_quest_bicycle_second_hand
override val isReplaceShopEnabled = true
override val achievements = listOf(BICYCLIST)

override fun getTitle(tags: Map<String, String>) = R.string.quest_bicycle_shop_second_hand_title
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class AddBoardType : OsmFilterQuestType<BoardType>() {
and access !~ private|no
and (!board_type or board_type ~ yes|board)
"""
override val changesetComment = "Add board type"
override val changesetComment = "Specify board types"
override val wikiLink = "Key:board_type"
override val icon = R.drawable.ic_quest_board_type
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AddBollardType : OsmElementQuestType<BollardTypeAnswer> {
and area != yes
""".toElementFilterExpression() }

override val changesetComment = "Add bollard type"
override val changesetComment = "Specify bollard types"
override val wikiLink = "Key:bollard"
override val icon = R.drawable.ic_quest_no_cars
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import de.westnordost.streetcomplete.osm.Tags
class AddBridgeStructure : OsmFilterQuestType<BridgeStructure>() {

override val elementFilter = "ways with man_made = bridge and !bridge:structure and !bridge:movable"
override val changesetComment = "Add bridge structures"
override val changesetComment = "Specify bridge structures"
override val wikiLink = "Key:bridge:structure"
override val icon = R.drawable.ic_quest_bridge
override val achievements = listOf(BUILDING)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class AddEntrance : OsmElementQuestType<EntranceAnswer> {
ways with (tunnel and tunnel != no) or (covered and covered != no)
""".toElementFilterExpression() }

override val changesetComment = "Add entrance info"
override val changesetComment = "Specify type of entrances"
override val wikiLink = "Key:entrance"
override val icon = R.drawable.ic_quest_door
override val achievements = listOf(PEDESTRIAN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class AddEntranceReference : OsmElementQuestType<EntranceAnswer> {
and !ref
""".toElementFilterExpression() }

override val changesetComment = "Add entrance identification"
override val changesetComment = "Specify entrance identifications"
override val wikiLink = "Key:ref"
override val icon = R.drawable.ic_quest_door_address
override val achievements = listOf(CITIZEN, BLIND)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class AddBuildingLevels : OsmFilterQuestType<BuildingLevelsAnswer>() {
and location != underground
and ruins != yes
"""
override val changesetComment = "Add building and roof levels"
override val changesetComment = "Specify building and roof levels"
override val wikiLink = "Key:building:levels"
override val icon = R.drawable.ic_quest_building_levels
override val achievements = listOf(BUILDING)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class AddBuildingType : OsmFilterQuestType<BuildingType>() {
and abandoned:building != yes
and ruins != yes and ruined != yes
"""
override val changesetComment = "Add building types"
override val changesetComment = "Specify building types"
override val wikiLink = "Key:building"
override val icon = R.drawable.ic_quest_building
override val achievements = listOf(BUILDING)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import de.westnordost.streetcomplete.quests.YesNoQuestForm
class AddIsBuildingUnderground : OsmFilterQuestType<Boolean>() {

override val elementFilter = "ways, relations with building and layer ~ -[0-9]+ and !location"
override val changesetComment = "Determine whether building is fully underground"
override val changesetComment = "Determine whether buildings are fully underground"
override val wikiLink = "Key:location"
override val icon = R.drawable.ic_quest_building_underground
override val achievements = listOf(BUILDING)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AddBenchStatusOnBusStop : OsmFilterQuestType<Boolean>() {
and physically_present != no and naptan:BusStopType != HAR
and (!bench or bench older today -4 years)
"""
override val changesetComment = "Add whether a bus stop has a bench"
override val changesetComment = "Specify whether bus stops have benches"
override val wikiLink = "Key:bench"
override val icon = R.drawable.ic_quest_bench_public_transport
override val achievements = listOf(PEDESTRIAN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AddBinStatusOnBusStop : OsmFilterQuestType<Boolean>() {
and physically_present != no and naptan:BusStopType != HAR
and (!bin or bin older today -4 years)
"""
override val changesetComment = "Add whether a bus stop has a bin"
override val changesetComment = "Specify whether bus stops have bins"
override val wikiLink = "Key:bin"
override val icon = R.drawable.ic_quest_bin_public_transport
override val achievements = listOf(CITIZEN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class AddBusStopLit : OsmFilterQuestType<Boolean>() {
or lit older today -16 years
)
"""
override val changesetComment = "Add whether a bus stop is lit"
override val changesetComment = "Add whether bus stops are lit"
override val wikiLink = "Key:lit"
override val icon = R.drawable.ic_quest_bus_stop_lit
override val achievements = listOf(PEDESTRIAN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ class AddBusStopRef : OsmFilterQuestType<BusStopRefAnswer>() {
and !ref and noref != yes and ref:signed != no and !~"ref:.*"
"""
override val enabledInCountries = NoCountriesExcept("US", "CA", "JE", "IE")
override val changesetComment = "Determine bus/tram stop ref"
override val changesetComment = "Determine bus/tram stop refs"
override val wikiLink = "Tag:public_transport=platform"
override val icon = R.drawable.ic_quest_bus_stop_name
override val achievements = listOf(PEDESTRIAN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AddBusStopShelter : OsmFilterQuestType<BusStopShelterAnswer>() {
/* Not asking again if it is covered because it means the stop itself is under a large
building or roof building so this won't usually change */

override val changesetComment = "Add bus stop shelter"
override val changesetComment = "Specify whether bus stops have shelters"
override val wikiLink = "Key:shelter"
override val icon = R.drawable.ic_quest_bus_stop_shelter
override val achievements = listOf(PEDESTRIAN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class AddCameraType : OsmFilterQuestType<CameraType>() {
and surveillance ~ public|outdoor|traffic
and !camera:type
"""
override val changesetComment = "Add camera type"
override val changesetComment = "Specify camera types"
override val wikiLink = "Tag:surveillance:type"
override val icon = R.drawable.ic_quest_surveillance_camera
override val achievements = listOf(CITIZEN)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import de.westnordost.streetcomplete.util.ktx.toYesNo
class AddCarWashType : OsmFilterQuestType<List<CarWashType>>() {

override val elementFilter = "nodes, ways with amenity = car_wash and !automated and !self_service"
override val changesetComment = "Add car wash type"
override val changesetComment = "Specify car wash types"
override val wikiLink = "Tag:amenity=car_wash"
override val icon = R.drawable.ic_quest_car_wash
override val achievements = listOf(CAR)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class AddChargingStationCapacity : OsmFilterQuestType<Int>() {
and !capacity
and bicycle != yes and scooter != yes and motorcar != no
"""
override val changesetComment = "Add charging station capacities"
override val changesetComment = "Specify charging stations capacities"
override val wikiLink = "Tag:amenity=charging_station"
override val icon = R.drawable.ic_quest_car_charger_capacity
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class AddChargingStationOperator : OsmFilterQuestType<String>() {
amenity = charging_station
and !operator and !name and !brand
"""
override val changesetComment = "Add charging station operator"
override val changesetComment = "Specify charging station operators"
override val wikiLink = "Tag:amenity=charging_station"
override val icon = R.drawable.ic_quest_car_charger
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class AddClothingBinOperator : OsmElementQuestType<String> {
and !operator and !name and !brand
""".toElementFilterExpression() }

override val changesetComment = "Add clothing bin operator"
override val changesetComment = "Specify clothing bin operators"
override val wikiLink = "Tag:amenity=recycling"
override val icon = R.drawable.ic_quest_recycling_clothes
override val isDeleteElementEnabled = true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class AddCrossing : OsmElementQuestType<KerbHeight> {
* tagging crossing=no on the vertex.
* See https://github.com/streetcomplete/StreetComplete/pull/2999#discussion_r681516203 */

override val changesetComment = "Add whether there is a crossing"
override val changesetComment = "Specify whether there are crossings at intersections of paths and roads"
override val wikiLink = "Tag:highway=crossing"
override val icon = R.drawable.ic_quest_pedestrian
override val achievements = listOf(PEDESTRIAN)
Expand Down
Loading

0 comments on commit 7c97885

Please sign in to comment.