From bc404b2c8f927a261be826e858725b0119c1c88c Mon Sep 17 00:00:00 2001
From: Mateusz Konieczny <matkoniecz@gmail.com>
Date: Thu, 24 Oct 2024 15:22:49 +0200
Subject: [PATCH] enable OH and wheelchair for more craft=

added some walk-in craft types into these quests
(triggered by mapping carft=window_construction in Places overlay
and not being asked OH quest, went looking what else is in iD
presets and missing here)

some other craft values where I was less sure:

craft = agricultural_engines
craft = basket_maker
craft = beekeeper
craft = blacksmith
craft = boatbuilder
craft = builder
craft = carpet_layer
craft = caterer
craft = chimney_sweeper
craft = cleaning
craft = confectionery
craft = electrician
craft = floorer
craft = gardener
craft = glaziery
craft = handicraft
craft = hvac
craft = insulation
craft = joiner
craft = metal_construction
craft = painter
craft = parquet_layer
craft = photographic_laboratory
craft = plasterer
craft = plumber
craft = pottery
craft = rigger
craft = roofer
craft = saddler
craft = scaffolder
craft = sculptor
craft = signmaker
craft = tiler
craft = tinsmith
craft = upholsterer

these values were found with a following Python script:

import taginfo

craft_values_supported_by_sc = ["carpenter", "shoemaker", "tailor", "photographer", "dressmaker", "electronics_repair", "key_cutter", "stonemason",
"jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker", "locksmith", "bookbinder", "window_construction", # added now
]

key = "craft"
project = "id_editor"
for value, entry in taginfo.analysis.get_tagging_supported_by_id_except_deprecations()[key].items():
    if(value == None):
        continue
    if value in ["brewery", "distillery", "winery", "oil_mill", "grinding_mill", "sawmill"]:
        # seem less likely to have walk-in visitors
        continue
    if(value in craft_values_supported_by_sc):
        continue
    print(key, "=", value)
    #print(entry)
---
 .../streetcomplete/quests/opening_hours/AddOpeningHours.kt    | 4 +++-
 .../quests/wheelchair_access/AddWheelchairAccessBusiness.kt   | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt
index fedbf25428..ecf923abb8 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt
+++ b/app/src/main/java/de/westnordost/streetcomplete/quests/opening_hours/AddOpeningHours.kt
@@ -87,7 +87,9 @@ class AddOpeningHours(
             "craft" to arrayOf(
                 // common
                 "carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
-                "electronics_repair", "key_cutter", "stonemason"
+                "electronics_repair", "key_cutter", "stonemason", "bookbinder",
+                "jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker",
+                "locksmith",  "window_construction",
             ),
             "healthcare" to arrayOf(
                 // common
diff --git a/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt b/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt
index d0cbdea8f4..5e1c7eb973 100644
--- a/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt
+++ b/app/src/main/java/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt
@@ -89,7 +89,9 @@ class AddWheelchairAccessBusiness : OsmFilterQuestType<WheelchairAccess>() {
             "craft" to arrayOf(
                 // common
                 "carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
-                "electronics_repair", "key_cutter", "stonemason",
+                "electronics_repair", "key_cutter", "stonemason", "bookbinder",
+                "jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker",
+                "locksmith",  "window_construction",
 
                 // name & wheelchair
                 "winery"