Skip to content

Commit

Permalink
enable OH and wheelchair for more craft=
Browse files Browse the repository at this point in the history
added some walk-in craft types into these quests
(triggered by mapping carft=window_construction in Places overlay
and not being asked OH quest, went looking what else is in iD
presets and missing here)

some other craft values where I was less sure:

craft = agricultural_engines
craft = basket_maker
craft = beekeeper
craft = blacksmith
craft = boatbuilder
craft = builder
craft = carpet_layer
craft = caterer
craft = chimney_sweeper
craft = cleaning
craft = confectionery
craft = electrician
craft = floorer
craft = gardener
craft = glaziery
craft = handicraft
craft = hvac
craft = insulation
craft = joiner
craft = metal_construction
craft = painter
craft = parquet_layer
craft = photographic_laboratory
craft = plasterer
craft = plumber
craft = pottery
craft = rigger
craft = roofer
craft = saddler
craft = scaffolder
craft = sculptor
craft = signmaker
craft = tiler
craft = tinsmith
craft = upholsterer

these values were found with a following Python script:

import taginfo

craft_values_supported_by_sc = ["carpenter", "shoemaker", "tailor", "photographer", "dressmaker", "electronics_repair", "key_cutter", "stonemason",
"jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker", "locksmith", "bookbinder", "window_construction", # added now
]

key = "craft"
project = "id_editor"
for value, entry in taginfo.analysis.get_tagging_supported_by_id_except_deprecations()[key].items():
    if(value == None):
        continue
    if value in ["brewery", "distillery", "winery", "oil_mill", "grinding_mill", "sawmill"]:
        # seem less likely to have walk-in visitors
        continue
    if(value in craft_values_supported_by_sc):
        continue
    print(key, "=", value)
    #print(entry)
  • Loading branch information
matkoniecz committed Oct 24, 2024
1 parent d573cf3 commit e385d76
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ class AddWheelchairAccessBusiness : OsmFilterQuestType<WheelchairAccess>() {
"craft" to arrayOf(
// common
"carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
"electronics_repair", "key_cutter", "stonemason",
"electronics_repair", "key_cutter", "stonemason", "bookbinder",
"jeweller", "sailmaker", "jeweller", "watchmaker", "clockmaker",
"locksmith", "window_construction",

// name & wheelchair
"winery"
Expand Down

0 comments on commit e385d76

Please sign in to comment.