Possibility to design "Note to self"

[mnalis]

Let's try to constructively design how we would want it to work, originally from #1992

Feel free to like/dislike each of the ideas for each of the tasks needed to solve the issue, or propose your own as a reply to the problem (I've tried to add main ones from #1992 but I've probably missed some)!

Main things to think about:

• more user friendly is better (SC is built around user-friendliness as a main principle!)
• more complete / more functional feature is better, unless it significantly detracts from user-friendliness
• if ideas are comparable, the one which is more simple to implement is better

[mnalis]

How to create a "private note"?

... and things to take in account while doing that.

[mnalis]

• private notes should be flagged as such, so they're never uploaded, and pictures should be in full size and quality (instead of reduced size and quality which public notes undergo to be published on the net)

[rhhsm]

pictures should be in full size and quality (instead of reduced size and quality which public notes undergo to be published on the net)

Doesn't matter, reduced size is still more than "good enough" to use, but if it's less trouble not to reduce them, that's fine too.

[mnalis]

v32 (in disabled-auto-upload mode) allows users to create notes, and then selectively delete them before uploading. In that case, private note is created the same as normal public note, but user deletes it before manually initiating upload.

[mnalis]

• one can use long press + Open location in another app in order to open note in some other app like notepad which supports geo: functionality. In such case, no additional support in SC is needed.

[Helium314]

Commenting here, even though it applies to more parts of this discussion:
As you noted, using v32 could remove the need for private notes as they can be checked before uploading.

So there could be a setting like don't upload new notes immediately, and when active one needs to tap the upload button for new notes to be uploaded. This makes finding notes in edit history much easier.
If auto-upload is disabled, upload button only upload notes if there is no quest/note comment to upload... maybe some indicator separating number of quests and number of notes might be useful here.
Or maybe the option could stop upload of new notes at all to avoid accidental upload. Or show a dialog...

Edit history would need to be changed a bit for nicer display of notes + images.

So now the notes can be checked and removed manually, or simply uploaded.
An export button/option could be implemented, showing the folder where notes should be stored as gpx + jpg.

[mnalis]

How to promote private note to public note?

(when promoted to public notes, pictures are resized and uploaded immediately if autoupload is enabled)

[mnalis]

• one of the ideas is to select a note (in the same way as if you wanted to comment on it) and have an extra options there. How exactly would that work and look (screenshot mockup) ?

[rhhsm]

Maybe the checkbox that marks it as a private note can be unchecked to upload it as public note? Low priority additional feature

[mnalis]

v32 (in disabled-auto-upload mode) allows users to create notes, and then selectively delete them before uploading. In that case, private note is created the same as normal public note, but users are expected to delete private notes before manually initiating upload - if they do not, the note is "promoted" to normal public note.

[mnalis]

How to find private notes created?

[rhhsm]

Public notes now have an extra high priority on SC so they are always shown on top of any other quest, isn't it? Private notes could be given the same or next-highest priority.

[mnalis]

@rhhsm I've also read in some ticket that Notes are given higher tangrem-es priority, but that feature does not seem to work reliably to me - either it is just "best effort", or it is buggy. Here is example of same area just slightly less zoomed - sometimes Notes are shown, sometimes not. I do not think that is something that can be counted on at the moment...

[rhhsm]

I expect that it won't be a problem in practice. Notes will be made during a survey, and many quests will be solved during that same survey so that the map will be relatively empty of quests right where the notes are. I also don't see it as a problem if occasionally a mapper misses a note or two because he can't find them. They will show up sooner or later.

[mnalis]

I'm not so sure it isn't a problem. See usage cases for quests presets for example (#2457), only a very few of them involve solving all quests in the area, in most cases only some (even very few) of the quests types are being solved. Also, such prediction depends much on mapper density - for exapmle, I do not expect quest map to EVER clear in my area, as before most of the quests are solved by existing mappers, they'd pop up again as resurvey quests. And that is not even counting new versions of SC which constantly add new quests.

[Strubbl]

If private notes are a type of quest like the public notes, one could put it at the beginning of the quest priority list in the settings "task selection". Icon can be the same like the public note but maybe a different color than red, e.g. blue instead of red.

[mnalis]

How to delete private notes when finished with them?

Needed so user knows what has s/he solved, and to free space taken by (full-size and full-quality) photos

[mnalis]

• if using list view of all private notes like https://my-notes.osm-hr.org/, there could be a separate delete button

v32 (in disabled-auto-upload mode) allows users to create notes, and then selectively delete them before uploading. This effectively implements this option. User clicks on undo button and the selects Show edit history, where all notes and quests are displayed, and user can click on each one to center map display on it and show note content, to manually add it in desktop editor before deleting it in SC. When all notes deemed private are deleted, user can do upload, and all remaining notes (the ones deemed public) will get uploaded with quests.

[mnalis]

• if notes could be "edited" by clicking on them (ie. there would be promote to public note and delete buttons, and not just comment button it has now). (Mockup screenshots needed)

[mnalis]

• if using "share" to desktop computer, the user could be asked after transferring all the files to desktop computer if s/he wants to delete them from mobile device

[rhhsm]

By tapping a public note on SC, there is the option to hide it. Similarly, when tapping a private note there could be the option to delete it (at the same spot where the "No, hide" option is for public notes).

[mnalis]

How to use private notes to actually solve them?

[mnalis]

• use android "share" functionality (which supports many ways of file transfer) to send .GPX file (with position and text of notes) and geolocated .JPG files (pictures) so user can open then in desktop editor and there are positioned at right places on the map. (advantages: no errors in location; it might also solve deleting task by asking after transfer if data should be removed from mobile)

[rhhsm]

Hmmm, that's indeed a tricky one I hadn't thought of. The ideal solution would be if private notes also appear in the editor on the big screen, but only if the author of the note is logged in in that editor. That would need uploading by SC and design development in those editors. But maybe users of JOSM and iD would also appreciate to be able to make notes on the map for themselves only?

[FloEdelmann]

Is it feasible to reach a change to the OSM (Notes) API? Then "private" could be a property of the note, nothing would need to be changed in other editors (they'd still see all notes), and the upload logic in StreetComplete could stay the same.

Or maybe a consensus could be reached on treating all notes starting with @osmUserName as private.

[mnalis]

@FloEdelmann While API change is possible (it had about 7 changes in last 12 years), it wouldn't mean anything without ALSO at least biggest of few dozen most popular editors adopting it, for which I guess idea should be much more widely popular (eg. several hundred users demanding it of their favorite editors, who would then ask it of OSMF to implement)...

@rhhsm if you only share data locally from your mobile to your desktop (using Android share button, for example via e-mail or bluetooth or ShareViaHTTP or whatever) then you don't need editors to be modified to take advantage of received data (at least JOSM doesn't need to be changed; I know iD allows GPX with named points to be imported which can be used for text notes, but I'm not sure if supports showing pictures automatically as JOSM does).

If you instead upload your notes somewhere outside of your own computer, then they're not really "private", even if they might be "not showing to other users by default" (and even that is assuming enough users can persuade various OSM Editors and OSMF servers to change the API)

[Strubbl]

It would be nice if i can export all private notes incl. their location, text and attached pictures. OsmTracker has a similar solution for export. This way i can download the export to my PC and use JOSM to edit.

After export and download to my PC, i want to go to the SC app and delete all private notes at once.

[mnalis]

Misc. discussion

If you don't find a better place, feel free to reply here to ask or express opinions etc.

[Helium314]

I recently added a VERY basic version of private notes (using a gpx file) into my modified version of SC, the note part is available here: https://github.com/Helium314/StreetComplete/tree/gpx_notes

This allows choosing between OSM notes and GPX when creating a note. OSM will behave like usual; GPX will not remove the involved quest (if any) and add the note to the file notes.gpx in <internal storage>/Android/data/de.westnordost.streetcomplete/files
The file is immediately written when creating a note, without any further checks. So there is a chance of crashing if the file can't be written (never happened to me).

Images are completely ignored, better don't try using them when creating a GPX note (I didn't check and they might just be stored inside some SC folder for all eternity).

This is not really meant to be included in SC, more for being able to do some "live testing" of private notes.

[mnalis]

@Helium314 it would be nice if you could make APK on Release page, so people without full android development environment might try it out and give comments.

[Helium314]

see https://github.com/Helium314/StreetComplete/releases/tag/v31.1_notes

[mnalis]

Why is it needed?

[mnalis]

• want to use short (and thus) cryptic notes like "S15 H+ R2" instead of typing longer text (and taking photo is not wanted as mobile might be locked to bicycle handlebar or to avoid provoking questions)

[mnalis]

• you don't speak English nor the language of the country in question, but noticed problem that you want to solve later when you get home

[mnalis]

• StreetComplete (sometimes) does not allow you to see public notes that you created yourself, and user wants to

[rhhsm]

• you don't want to bother other mappers with your notes because you anticipate they will start complaining about them

[Strubbl]

a high number of notes in a small area is possible this way.

Othwise a high number of notes in a small area and short time bothers other mappers because

• they receive a notification for every created note in their watched area (e.g. via RSS) or
• they see the forest of notes as pollution of the osm.org map or
• they misinterpret the open note as a task i am assigning for them although i am a mapper and can solve this by myself

that's what i was told when creating ~20 notes in a small area.

[rhhsm]

This discussion has been quiet for some time, maybe because we're almost there with the v32 option to list and revert edits and to choose manual upload. In this way, notes which are meant to be private can be solved and then reverted before the other edits from the survey trip are uploaded. This works fine for me, except that it's cumbersome to find the notes in a list that can become very long (several hundred items). I've be fully satisfied if notes could be made more easily visible by the author: now notes are "notes to everybody except self". Could notes be made visible to the author who created them, and a simple revert/delete button added to them, only visible to the author, so they can be easily deleted before upload?

[mnalis]

Also related: GPX notes in @Helium314 fork mentioned at #3003 (reply in thread) are a variant of private notes?

[rhhsm]

Another weakness of the present possibility to search for "notes to self" in the list of edits is that you can only see the text of the note to be reverted, but not any photos you may have taken as illustration. At present, images can only be seen by the note's author in a Windows editor, after upload.

[ppete2]

The last weeks I noticed a few new OSM-mappers which are using StreetComplete and opened DOZENS of public notes each day. And to be clear: This aren't notes as they should be used: to report an error in the data and ask OTHER mappers for help or their opinion. No - they have been just used as private reminders, to fix some SC-question at home. This is not what OSM-Notes are for: "Dont' use them just as private reminders": https://wiki.openstreetmap.org/wiki/DE:Notes

This behaviour of StreetComplete is really dissappointing, cause the map is cluttered by such private notes, and complicates locating the "real" notes adressing other mappers.

I already wrote to such newbies, and in general they answer: They didn't know about this fact and would be happy if a "reminder" function within SC would exist.

Please introduce this feature "private notes", to make SC users being able to create such reminder-notes which are just stored on their local phone.

[mnalis]

The last weeks I noticed a few new OSM-mappers which are using StreetComplete and opened DOZENS of public notes each day.

@ppete2 could you link to few of them, please?

This aren't notes as they should be used: to report an error in the data and ask OTHER mappers for help or their opinion.

I'm not sure about DE translation; but default English version of that page says "Although you can use notes as a reminder to yourself, you are also inviting others to look at it. Descriptions must make sense to other people." which seems somewhat different definition. But I absolutely agree with you that public Notes should be solvable by anyone, not just their creator.

This behaviour of StreetComplete is really dissappointing

You mean, behavior of StreetComplete users? StreetComplete app itself allows creating OSM Notes, as do many other OSM editing tools. Especially, when creating a new note, StreetComplete tells the user: "You can leave a note to let other mappers know about an issue here".
I don't know if German translation is lacking there, perhaps that can be improved? Or do you have suggestion what it should say to be better understandable, or how to make it more visible?

Please introduce this feature "private notes", to make SC users being able to create such reminder-notes which are just stored on their local phone.

That feature is implemented in SCEE fork of StreetComplete, if someone is interested in using that functionality right now.

(manual ref.: @ppete2 complaint is also crossposted at #1992 (comment); as GitHub does not implement linking issues with discussion I'm also mentioning it here)

[mnalis]

Also, as a workaround, if one does not find Notes left by StreetComplete (or EveryDoor or any other tools that leaves a signature/hashtag in Notes) of high enough quality and wishes to ignore them (and/or only ignore Notes from specific users etc), one can use various OSM tools to filter them out, like:

• https://antonkhorev.github.io/osm-note-viewer/ for one-time review of filtered notes (because NotesReview, which is easier to use, does not yet allow for inverted filtering)
• for regular area patrolling, I'd recommend using excellent https://tyrasd.github.io/osm-qa-feeds/ which can produce RSS feed of new notes for specific area (as well as many other QualityAssurance tools for areas!), which has many benefits (there are many RSS readers to choose and they allow for custom filtering, but most importantly, you only need to check new notes once instead of re-reading them every day/week, and you can favourite or mark them as read/unread as you wish. Huge time saver, and makes many things much easier like marking some notes for later review etc!)

[Helium314]

I agree here, using proper tools for note management is a far better solution than pestering users about not creating notes with wrongly claiming the are "private notes".
Also has the advantage that users keep adding details via their notes, whether the solve the notes themselves or not.