v32.0-alpha1

[westnordost]

The grant from the Prototype Fund ended in February, however, there is one last big mega-update I can delight you with before development on this app must necessarily wind down:
It may not look like a lot, but I basically replaced the whole architecture of the app (#2506, ...) to do this. Special thanks to @FloEdelmann for helping with the refactor.

🔙️ Superpowered Undo

• You can now undo any edit that hasn't been uploaded yet:
  Quest answers, split ways, deleted places, hid quests, created notes and note comments (Make it possible to show again “Can't say” notes/the original question #1029, Undo not uploaded notes #2616)
• You can now look at your edit history and undo any recent edit in any order, not just the last one
• It is now shown what exactly is tagged for each edit in the edit history
• You can now undo deletions of places even after you have already uploaded it ("Does this still exist?" cannot be undone #2441)

⛰️ Improved usability and offline mode

• Immediately unlock new quests based on the one you just solved, also when offline. This has been a much requested feature but was simply not possible with the previous architecture (No house number quests displayed #1369, frustration with running to the same places over and over again #1510, Please prefetch common questions as results of quests #1550, Ask all questions for an object, for that way user not have to selected it twice or more.  #1826, in offline mode, ask all tasks on a building #2254, Consider quest dependencies #2438, Give house number quest a higher priority #2473, house number quest only appears several minutes after building type is added #2474, Gebäudeeigenschaften direkt nacheinander erfassen #2676, Asking for addr:street if addr:housenumber has just been added #2743...)
• The above also works when splitting a way. The quests for the split segments will be shown immediately
• When you scan for quests manually, no cache will be used: You always get the most fresh data (automatically invalidate an area when manual quest scan is initiated #2554)
• When unable to fully upload pictures attached to a note due to a bad connection, the app will try again later (Retry activating photo in note on timeout #2102)

New Quests

• Is this sport field lit? (Sport pitch lighting #2639, Add sports pitch lighting quest #2737), by @eginhard
• What type of barrier is this? (Change barrier=yes on nodes into more specific values #2739, Barrier, fixes #2739 #2753), by @matkoniecz
• What type of stile is this? (Stile type #2749, Tag stile type, fixes #2749 #2766), by @matkoniecz
• What type of shop is this? (Ask which specific shop is here (for shop=yes objects) #2391, Ask which specific shop is here on shop=yes #2759), by @matkoniecz
• Italy only: Which type of police station is this? ([Quest suggestion] Which kind of police station is this? (Italy and France, maybe too specific?) #2456, Add police type quest (Italy only) #2675), by @naposm

Other Enhancements

• Enable answering that the cycleway is displayed separately on the map (Support bicycle=use_sidepath #2525, Support cycleway=separate (fixes #2525) #2665)
• Some wording improvements (clarify crossings where there is a blinking traffic light [review of proposed change is welcomed] #2728), by @matkoniecz, (Improve check existence quest wording #2806, Improve check existence quest wording for named things #2814) by @peternewman, (Inaccurate description for semi-detached house #2685)
• Enhance maxspeed collection for the United Kingdom (Maxspeed quest should tag a road as lit when that is asked #2745, National Speed Limit option for maxspeed quest in GB #2748, Maxspeed type on trunk roads and living street #2750, Remove trunk from definite maxspeed type in GB #2811), by @arrival-spring
• Periodically ask for the existence of bbq spots, ticket validators, emergency life rings and emergency phones ("Is this still here?"-quest for emergency=access_point #2679), thanks @arrival-spring
• Also ask for the surface of service roads as long as they are not driveways (Include highway=service in surface quest #2783)
• Slightly more performant compass

Fixes

• On tablets, correctly restore the position when reentering the app (after everystart oft streetcomplete the map open in north of italy #2659, Do not zoom to somewhere-in-Italy at startup #2311), thanks @matteblair
• Sometimes the link collection wouldn't show (OSM link display sometimes broken(?) #2801, Replace awaitPreDraw with awaitLayout (fixes #2801) #2809), by @tapetis
• The keyboard would not appear in the opening hours times dialog (Keyboard doesn't appear when using the time input fields in the opening hours quest #2799, Fix keyboard not appearing in TimeRangePickerDialog (fixes #2799) #2820), by @tapetis
• The flags in the statics view were sometimes wrongly stretched ([already in v31] at least some flags are overly stretched horizontally #2819, Reset flag offset after onMeasure #2831), by @tapetis
• The time picker for the postbox collection times now follows the system settings (opening_hours and collection_times quests use different time-picker (12h am/pm vs. 24h) #2807)
• Fix crash on trying to display opening hours that range to 24:00 ([v32.0-alpha] crash at opening hours quest #2830)
• ...and other fixes and enhancements (Create and use wrapper for SQLite database #2521, Quest Search icons sometimes get stuck onscreen #1821, Disappearing quests #2628, replace QuestGroup + id with each quest type defining its own key #2691, Zoom level sometimes changes after bringing back SC to the foreground #2715, clarify crossings where there is a blinking traffic light [review of proposed change is welcomed] #2728...)
• Remove checking existence of grit bins, as many are removed for summer and not marked as seasonal :( (Check for existence of grit bins #2726), by @matkoniecz

---

This discussion was created from the release v32.0-alpha1.

[westnordost]

You are very welcome to help testing it! If you do, please report any issues you find back here or in the bugracker!

This version is only available as a direct APK download on GitHub, but when I publish a newer version on Google Play, it will automatically update to that version (so you won't need to remember updating).

[peternewman]

Installed via APK, should this have rest my disabled quest settings (which it definitely has done) and possibly the order (which I'm less certain of)?

[matkoniecz]

Yes, it is expected - see #2840 (comment)

Quest order should survive.

[peternewman]

It probably did, I was less sure on that.

I'd suggest the changelog for this release should have a note at the top about that, as well as, and far more importantly, the warning from the top of the previous releases: https://github.com/streetcomplete/StreetComplete/releases/tag/v31.3

[lukashass]

Just installed this on Android 11. I had to uninstall the old version first. When v31.3 was still installed the installer failed with App not installed.

[mnalis]

same thing happened to me; but I think it is because I had v31.3 installed from f-droid, which uses different signing key than Google Play (and github APK). If so, that is normal behaviour (security protection so application can only be upgraded from the same source it was installed from). Also related: #2842

[westnordost]

Correct, the release from F-Droid is signed by F-Droid, the releases on GitHub and Google Play are signed by me. Installing one over the other is not possible.

So if you got StreetComplete from F-Droid, you need to uninstall it first.

[peternewman]

I had an instance once where it was showing e.g. road quests, but when you tapped on the pin it didn't show the outline of the way. It might still have been scanning. I couldn't reproduce it afterwards.

[peternewman]

I think I just did a force quit and reopened it and it was fine, whatever that means, I guess that ties up with the UI thing.

[westnordost]

Hm, it did not ask you to send an email about the crash?

[peternewman]

It didn't crash, I just did a long press>App info>Force Stop to get it to reload, at which point it was behaving correctly.

[peternewman]

Just to say I've had the same thing again. I resolved it again with another Force Stop. Different location this time, but after the relaunch it again showed the geometry for those roads again (it was doing the same thing for two this time). Again no obvious reproduction.

[westnordost]

I created an issue: #2862

[peternewman]

I added the building levels (but not roof levels) to a building (as it was down the end of a street so I couldn't be certain if it had dormers or Velux windows. It then offered the house number quest, which was all good (although I hadn't remembered seeing it for the other buildings). However when I manually scanned quests it then showed the roof type quest. It didn't seem to immediately update when I changed the selected/enabled quests either.

I've not tried reproducing yet but haven't seen it since when using the alpha...

[westnordost]

auto-sync on or off?

[westnordost]

How many building levels did you add?

[westnordost]

Anyway, I can't reproduce this. No roof levels given is treated the same way as 0 levels given in respect to whether the roof shape quest is shown or not.
So this means that this is not a problem specific to the roof shape quest. The one way I can think of how this quest could not have been unlocked is if the geometry of that building was invalid. Which then would be the same cause as #2862

[peternewman]

auto-sync on or off?

My auto-sync is only on WiFi, I think I was offline at the time, so I thought all the shiny new offline features should make that irrelevant.

How many building levels did you add?

2

Anyway, I can't reproduce this. No roof levels given is treated the same way as 0 levels given in respect to whether the roof shape quest is shown or not.
So this means that this is not a problem specific to the roof shape quest. The one way I can think of how this quest could not have been unlocked is if the geometry of that building was invalid. Which then would be the same cause as #2862

I'm 90% certain it was showing the correct building shape/geometry when I entered the levels quest.

I should clarify I've got quests in this order:

1. Building kind
2. Levels
3. House number

The in-place upgrade wouldn't need a re-order to get it to re-read quest order would it?

[lukashass]

I encountered some cases where the house number quest seems to be blocked by building levels (and roof shape quests).

1. I had building levels disabled and wondered why no house number quest was offered.
2. I then deleted all app data and saw the building levels quest.
   1. When disabling the building levels quest at this point no quest is offered.
   2. When answering the building levels quest, the house number quest is offered.
      1. When scanning for quests at this point the house number quest will be replaced by the roof shape quest.

This is the case on:

• https://www.openstreetmap.org/way/450582253
• https://www.openstreetmap.org/way/494982835
• https://www.openstreetmap.org/way/494981018

On a lot of other buildings I was able to answer quests in the (expected?) order of building type, house number, street.

[westnordost]

So, it's not just a display issue - that building levels is displayed wrongly in front of house number - but that as long as the building levels quest is not solved, the house number one does not show up?

[lukashass]

I think so, yes. When the building levels quest is disabled there is no quest displayed on the buildings mentioned above.

Sounds like I should be able to switch between available quests. Am I missing something?

[westnordost]

You can't switch, but you could disable a quest type to see if anything is "underneath" it

[lukashass]

Ah, yes. That's what I did. There is nothing underneath.

[peternewman]

Maybe this is also what I saw in #2834 (comment) and I'm miss-describing/miss-remembering it.

[westnordost]

alpha2 and hopefully the last alpha before the public beta is out with most issues found during alpha1 testing fixed!

https://github.com/streetcomplete/StreetComplete/releases/tag/v32.0-alpha2

[RubenKelevra]

I noticed a performance issue which leads to stuttering:

Steps to reproduce

• Zoom out
• select a quest
• complete it

Example

21-05-17-20-46-00.mp4

The view will zoom out automatically, while the answer is processed. This leads to visual stuttering even on a fairly powerful device:

Snapdragon 835
8 Gigs of RAM
UFS2.1 Storage
Android 11

So on less powerful devices this is probably more prominantly.

I suggest to let the animation finish before processing the answer. This way we can "hide" the stuttering most of the time, when the user is deciding what to click next.

[westnordost]

Hm this is not new though, is it?
Just checked, the processing is not done on the main thread. So, I am not sure, but likely, the stuttering is caused by the updating of the map view (i.e. in this case, remove that one quest pin), not the processing itself.

Removing a quest pin is actually not possible in the map rendering library I use (tangram-es), so what happens instead is that all pins are removed and re-added (minus the one that should be removed). Nothing changed here since v31.

But yeah, maybe a mitigation would be to only do the zoom out animation after the pins have been updated

[westnordost]

Oh well, I found a small thing that could be improved: Instead of zooming out immediatly on answering the question (before processing), zoom out when the processing is done and the quest is removed as a consequence of that. This still happens at the same time as the map updates its pin, but then I think the stuttering should be less noticeable as it should now happen not in the midst of the animation but somewhere at the start of the animation.

[westnordost]

At least - I didn't try it before changing this, but now I notice no stuttering at all. Same specs as your phone only instead a Snapdragon 855