Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New building type quest doesn't seem to lead to housenumber quest #1119

Closed
dbdean opened this issue Jul 5, 2018 · 2 comments
Closed

New building type quest doesn't seem to lead to housenumber quest #1119

dbdean opened this issue Jul 5, 2018 · 2 comments
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@dbdean
Copy link
Contributor

dbdean commented Jul 5, 2018

When I set a building=yes to building=detached with the new building type quest, it doesn't seem to show house number quests, until after I invalidate and reload the quests.

It does show building level quests though, although they don't show up immediately, you have to wait for the new building level quest icon to appear and click on it.

@matkoniecz
Copy link
Member

matkoniecz commented Jul 5, 2018

tl;dr that is because everything is more complicated than expected

That is caused by complexity of housenumber quest. Some quests are based just on tags of object, for example after answering what is the name of restaurant questions about opening hours and so on are automatically generated.

But for address quest checking value of building tags (is it =detached or =apartment or ...) is only one of checks.

Other check include for example "not inside area that has address" (to handle cases where for example hospital buildings have no addresses, there is one address assigned to the entire hospital).

Currently such complicated queries are not handled locally, only in overpass requests. The same applies for example to cycleway quest.

See https://github.com/westnordost/StreetComplete/blob/master/app/src/main/java/de/westnordost/streetcomplete/quests/housenumber/AddHousenumber.java#L234

Whether this element applies to this quest cannot be determined by looking at that element alone (see download()), an Overpass query would need to be made to find this out. This is too heavy-weight for this method so it always returns false.
The implications of this are that this quest will never be created directly as consequence of solving another quest and also after reverting an input, the quest will not immediately pop up again. Instead, they are downloaded well after an element became fit for this quest.

I expect that implementing half of overpass API and filtering OSM data and keeping all relevant data in smartphone is not planned to be implemented.

This would take massive development effort - I would expect something like 1000 hours of work (note, it may turn out to be 500 hours or 10 000 hours - estimations of time necessary for making software are notoriously unreliable).

And in addition, it would not be able to properly run on the smartphone due to missing memory, limited CPU and limited battery. So at this point this is not worth doing anyway.

EDIT: Note that @westnordost actually implemented this some time later and it works nicely :)

@mnalis
Copy link
Member

mnalis commented Jun 8, 2021

Just to note that this was actually fixed in v32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

No branches or pull requests

4 participants