Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quest: Ask if a fuel station offers self service #1827

Closed
5 tasks done
naposm opened this issue May 14, 2020 · 33 comments · Fixed by #2822
Closed
5 tasks done

New quest: Ask if a fuel station offers self service #1827

naposm opened this issue May 14, 2020 · 33 comments · Fixed by #2822
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@naposm
Copy link
Contributor

naposm commented May 14, 2020

General

Affected tag(s) to be modified/added: self_service
Question asked: Does this fuel station offer self service? (yes / no / only)

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by everyone from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of elements have the same answer (No spam)
  • 🕓 Applies to a reasonable number of elements (Worth the effort)

Ideas for implementation

Like most of the quests there's a question and three option: yes, no or only when the fuel station only offers self service.

Element selection:

/*
This has been generated by the overpass-turbo wizard.
The original search was:
“amenity=fuel and self_service!=*”
*/
[out:json][timeout:25];
// gather results
(
 // query part for: “amenity=fuel and self_service!=*”
 node["amenity"="fuel"]["self_service"!~".*"]({{bbox}});
 way["amenity"="fuel"]["self_service"!~".*"]({{bbox}});
 relation["amenity"="fuel"]["self_service"!~".*"]({{bbox}});
);
// print results
out body;
>;
out skel qt;

Metadata needed: It would be useful in Italy since not every fuel station has self service and a lor of them aren't tagged as self service anyway.

Proposed GUI: (may make an image later)

Does this fuel station offer self service?
yes no only offers self service
@westnordost
Copy link
Member

In Germany at least, I haven't seen one fuel station that is not self service. So, it must be researched first in which countries it would be reasonable to ask.

@RubenKelevra
Copy link
Contributor

Yeah, for Germany and most of Europe this would probably be just spam - since all of them are only self-service.

In Greece (some years ago) I encountered some non-self-service fuel stations. But I'm not sure how this looks today.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 14, 2020
@matkoniecz
Copy link
Member

And in USA it depends on state, AFAIK some make self-service illegal.

@smichel17
Copy link
Member

I think that's down to just New Jersey, now.

@Atrate
Copy link
Contributor

Atrate commented May 15, 2020

Poland has quite a few non-self-service gas stations to be honest

@westnordost westnordost added the help wanted help by contributors is appreciated; might be a good first contribution for first-timers label May 15, 2020
@westnordost
Copy link
Member

Ok well, we need a list of countries where this concept exists. We now have PL, US-NJ. Anyone willing to do the research? Maybe @naposm ?

@smichel17
Copy link
Member

US-NJ should not offer the quest because there are no self-service gas stations, by law.

@naposm
Copy link
Contributor Author

naposm commented May 15, 2020

@westnordost According to Wikipedia, I can say Japan (they call them serufu). In Italy we also need some self service tagging. Then, according to this article from CarRentals.com it could be useful in these countries: developing countries, China, New Zealand, France, Greece, Hungary, Iceland, Portugal, Argentina, Canada, Chile

For now illegal self service is in Brazil, US-NJ, US-OR (tem. lifted), South Africa, the town of Weymouth, Massachusetts, and the town of Huntington, New York.

@CalliOSM
Copy link

In Albania most fuel stations offer fuel service

@westnordost
Copy link
Member

Before I mark this as "new quest for certain countries", @naposm can you explain what practical use this information has?

@naposm
Copy link
Contributor Author

naposm commented May 17, 2020

@westnordost I thought it might be useful to add this information because no one tags it and it was essencial on Ca reste ouvert until some weeks ago, when it only showed fuel stations with self service. Now it has been changed to show them all, but in the future it might be useful to have this kind of information because it might be a good filter on navigators for people traveling abroad.

@westnordost
Copy link
Member

Ah, so the information can be used as similarly to opening hours - if it is not self service, it may have shorter opening hours (if the opening hours field is not specified).
Still, quite an unimportant info, would probably be quite low in the list.

@westnordost westnordost added new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) and removed feedback required more info is needed, issue will be likely closed if it is not provided help wanted help by contributors is appreciated; might be a good first contribution for first-timers labels May 18, 2020
@peternewman
Copy link
Collaborator

Then, according to this article from CarRentals.com it could be useful in these countries: developing countries, China, New Zealand, France, Greece, Hungary, Iceland, Portugal, Argentina, Canada, Chile

I've driven through quite a lot of France over the years and never not done self-service from my memory. Talking to a Kiwi there may occasionally be assistants in NZ but it's optional and rare. I don't particularly remember them in Iceland, but that was a long time ago so things may have changed anyway.

This also might not be a good one to collect currently given some places may possibly be doing things differently during the pandemic.

@kjonosm
Copy link

kjonosm commented May 21, 2020

@RubenKelevra
Copy link
Contributor

Before I mark this as "new quest for certain countries", @naposm can you explain what practical use this information has?

Practical use might be for disabled people, to find a fuel station where they don't have to squeeze themselves between the car and the fuel pump and walk into the shop, but instead, have someone to help them or do the fuel service for them.

@Mannshoch
Copy link

Mannshoch commented Jun 9, 2020

https://www.handicap-search.ch/tankstellen/

(Does OpenStreetMap work together with such Organizations to map such data?)

@naposm
Copy link
Contributor Author

naposm commented Apr 28, 2021

Hello everyone! 🤗 I tried to implement this today and somehow it works.

More precisely, I implemented two quests: one for full service and another one for self service, following the wiki.

I did this because I think that the full service tag is useful for people with disabilities as @RubenKelevra suggested, while the self service tag is a tag that might be useful (see the reason why I opened this issue, Ca reste ouvert, which was a very useful project last year required the self service tag on fuel stations to choose which ones to show).

They both are very low in the list, in their respective sections.

I made some tests and will leave some screenshots. I recycled the police type icon for now, but if @westnordost agrees and thinks this is useful I can take time and make the icons and open a pull request.

Self service quest:

Debug:

Answer "YES":

Answer "NO":

Full service quest:

Debug:

Answer "YES":

Answer "NO":

Answer "It only offers full service":

@matkoniecz
Copy link
Member

@naposm

westnordost added new quest and removed feedback required help wanted labels on May 18, 2020

Idea of the quest is accepted already, so PR may be opened

One annoying and time consuming part will be researching where this quest should be asked and in which countries it is useless (I cannot check that as it appears as this quest branch is not yet pushed to a public repo - https://github.com/naposm/StreetComplete/branches/active )

Note that full_service tag is barely used, just 200 uses worldwide so it may be a good idea to check on tagging mailing list is it a good idea to start adding it on all fuel stations (is it good enough for SC quest?).

@westnordost
Copy link
Member

I also don't know what "full service" is supposed to mean? That it also has a shop? That there are vacuum cleaners and tyre inflators available? 🤷

@naposm
Copy link
Contributor Author

naposm commented Apr 28, 2021

One annoying and time consuming part will be researching where this quest should be asked and in which countries it is useless (I cannot check that as it appears as this quest branch is not yet pushed to a public repo - https://github.com/naposm/StreetComplete/branches/active )

I'm pushing this right now so you can see

Note that full_service tag is barely used, just 200 uses worldwide so it may be a good idea to check on tagging mailing list is it a good idea to start adding it on all fuel stations (is it good enough for SC quest?).

I had this doubt, but it's in the wiki so I think it's "official", anyway if anyone can help me to sort this out I'd be very glad, I can try to send a mail tomorrow, but I don't know if I have to make a formal request or anything on the wiki.

I also don't know what "full service" is supposed to mean? That it also has a shop? That there are vacuum cleaners and tyre inflators available? shrug

I think it means there's an operator, that's what I understood, we call it "Servito" here in Italy.

@RubenKelevra
Copy link
Contributor

I also don't know what "full service" is supposed to mean? That it also has a shop? That there are vacuum cleaners and tyre inflators available? 🤷

Yeah I think it makes more sense to do individual tags for those amenities (somehow) which might also have different opening hours, like a car wash and vaccum cleaners might not be available during the night, while a tyre inflator is, as well as the shop and fuel.

Might not be super critical, but it would be neat if we could help motorists to find the right station and keep the details up to date. :)

@matkoniecz
Copy link
Member

If meaning is unclear then it should not be included in SC.

Note that OSM Wiki may be edited by anyone at all, in the same way as OSM map data.

@smichel17
Copy link
Member

"Full service" is a term I know and (prior to a few minutes ago) would have assumed is common knowledge. It means that you don't pump your own gas; you drive up and roll down your window; an employee will come over and you'll tell them what you want (e.g. full tank of regular) and pay; they pump the gas and hand back any change / your card; and you drive off.

@westnordost
Copy link
Member

Where is the difference to self_service=no then?

@riQQ
Copy link
Collaborator

riQQ commented Apr 28, 2021

Probably to tag a gas station that has both options (see also OSM wiki).

@naposm
Copy link
Contributor Author

naposm commented Apr 28, 2021

Where is the difference to self_service=no then?

I think that's only a way to say that there's no self service, the full service should be mandatory in that case (or assumed)

@naposm
Copy link
Contributor Author

naposm commented Apr 28, 2021

@matkoniecz I just pushed my code on my fork now if you want to see

@opk12
Copy link

opk12 commented Jun 7, 2021

Nice work. I have read the PR and like this quest. I would like to share a couple of thoughts.

Should Only be prominent, next to Yes and No?

If offered a binary choice, I translate "self-service only" to Yes and don't bother looking around under Other answers, which usually has exceptional cases for inability to answer. If I had not seen the screenshots above in the issue and read the wiki, I would not have imagined the choice is ternary and has an answer under the menu.

Is tagging the self-service / full-service hours being implemented or planned? (self_service:conditional / full_service:conditional wiki)

If it is not being implemented: does answering Yes today prevent the station from being targeted by a future, hypothetical hours quest? Here where I am, a station with both self_service=yes and full_service=yes always offers them on different hours, so that's the POI filter condition for a hypothetical hours quest. But if, somewhere else in the world, self-service depends only on the driver's choice, or vehicle type, or something else that cannot be programmatically filtered out, then a hypothetical hours quest would have to exclude a station that has both yes (No unanswerable quests)

@opk12
Copy link

opk12 commented Jun 7, 2021

  1. Italian law forbids self-service LPG (GPL in Italian) so what about having only the options No and Leave a note; or auto-tagging No; or adding fixme=* if Yes is chosen? I imagine there may be other countries with similar restrictions, where the approach would then be reused.

(Self-service CNG (metano in Italian) has historically been illegal, but it seems legalized since recently, from Google)

@mnalis
Copy link
Member

mnalis commented Sep 12, 2021

In Croatia also LPG is always done by attendant, but all fuel pumps for standard gas/diesel cars I've ever seen are self-service by default (although you can almost always call attendant to do it for you, and sometimes they might approach themselves if they see you're confused). After filling the tank, you have to go in to the cashier to actually pay (for vast majority of them - there are few which are fully autonomous)

(It might differ for fuel for HGV / yachts, though)

@naposm
Copy link
Contributor Author

naposm commented Jan 15, 2022

Grazie @opk12 per le informazioni!

what about having only the options No and Leave a note; or auto-tagging No; or adding fixme=* if Yes is chosen? I imagine there may be other countries with similar restrictions, where the approach would then be reused.

Unfortunately I'm not sure I'd be able to do it now, but maybe in the future I will.

For now I decided to just remove the full service quest since the tag is too new and not "officially" adopted.

I apologize for just noticing these comments!

@opk12
Copy link

opk12 commented Jan 15, 2022

@naposm Thank you for your great work. BTW You may want to get in touch with the Italian community's chat, if you're not already on matrix or telegram already.

@naposm
Copy link
Contributor Author

naposm commented Jan 16, 2022

Sure, I can join the conversation via Matrix 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.