Unable to select the Sidewalk overlay if there is a Note on it

[mnalis]

Once upon a time I left a note when answering Sidewalk quest. Now, when I enable Sidewalk overlay and try to click on that way (not on the note!), instead of opening Sidewalk overlay answer window, it opens that Note.

How to Reproduce

• enable Sidewalk overlay (and disable all quests if wanted)
• navigate to this Vinkovačka ulica road
• try to click on the road far away from the note
• Note window opens

small_SVID_20221019_003737_1.mp4

Expected Behavior
I would expect that instead of the Note window, an Sidewalk overlay chooser would open.

Versions affected
Both SC 47.2 upstream, and my fork with 48.0-beta1+; Android 10

[mnalis]

It also happens with other way-related overlays, e.g. Street lightning overlay or Street parking overlay when clicking on that way.

[westnordost]

This is a feature, not a bug.

[mnalis]

Oh, OK. It confused me a lot, but I guess it can be documented in FAQ. But how is one supposed to handle that case with StreetComplete only (i.e. fix the overlay on that street)? Or is that use case (editing roads on which someone has left a Note) not (currently) supported by SC?

Because there does not seem to be a way to actually close the note as far as I can tell. (I wanted to close the note so that I presumably could progress to be able to use Sidewalk Overlay on that street).

Clicking hide does remove the note marker from the map, but clicking on the street in overlay brings up the Note again anyway. If one happens to click hide again, the StreetComplete crashes (I've sent the crash report email about it now, so I guess you have it recorded somewhere so you don't need me to open another issue for that crash?)

Maybe the Overlay editing may be allowed if the SC user has manually hidden the Note?

[westnordost]

Well that's how the notes work. They block all quests until they are solved, because something is amiss that must be solved first (outside of the app). And hence, also all editing with overlays.

However, thank you for the hint regarding the crash, I'll have a look.

[mnalis]

(added a FAQ entry)

[westnordost]

I added a fix now. It will not crash anymore. Instead of "No, hide" if it is already hidden (as a quest), just "No" is displayed, which just closes the form. (Hiding has no effect on it being shown in overlays, only it being shown as a quest.)

92b2734