Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force refresh if quest cache is very old #766

Closed
matkoniecz opened this issue Jan 14, 2018 · 8 comments
Closed

force refresh if quest cache is very old #766

matkoniecz opened this issue Jan 14, 2018 · 8 comments
Milestone

Comments

@matkoniecz
Copy link
Member

matkoniecz commented Jan 14, 2018

https://www.openstreetmap.org/note/1267879 answered 2 hours ago to quest that was outdated since 5 months https://www.openstreetmap.org/node/258828603/history

next case - https://www.openstreetmap.org/note/1381967#map=18/50.73701/7.10388 that triggerred #1046

I think that quests older than 1 month should be invalidated, no matter whatever user downloaded new or not.

@matkoniecz
Copy link
Member Author

Given earlier edits like https://www.openstreetmap.org/changeset/55414660#map=19/48.58106/7.77016 I think it is safe to rule out situation of answering months ago and uploading answers now.

@westnordost
Copy link
Member

However, if someone is explicitly downloading an area for offline use later, these quests should be save from auto-deletion, shouldn't they?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Jan 14, 2018
@matkoniecz
Copy link
Member Author

Yes, that is why I think 1 month is a good limit.

@westnordost
Copy link
Member

But how to communicate this to the user? Or do you think it does not need to be communicated?

@matkoniecz
Copy link
Member Author

I think that silent deletion after month is OK.

I am not sure is it necessary to handle usecase of caching quests for months. At this moment SC is anyway not supporting well such large-scale offline editing as there is no way to cache map for any substantial area (scrolling through map to download works for areas up to a small town).

If one want to warn user there is one complication - any message about quests about to expire would also be displayed to any users who edited in some location is past and stopped doing this (they were on holidays or some other trip).

@rugk
Copy link
Contributor

rugk commented Jan 14, 2018

If this background information is really necessary to communicate (in the unlikely chance that any user encounters it), just put it into the FAQ. Such a question may answer cache invalidation things in general… I think that is also a quite common question (i.e. something like "What effect does the setting for quest invalidation in the settings have?")

@matkoniecz
Copy link
Member Author

added the feedback required label 12 days ago

I tried to answer in #766 (comment) - let me know if anything is unclear/not explained.

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Jan 27, 2018
@leftshift
Copy link

We could add a warning about this when disabling auto-sync, which is probably the most likely way to end up with old completed quests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants