Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreetComplete banned / Undo Feature was broken Jan 7 - Feb 9 #852

Closed
westnordost opened this issue Feb 9, 2018 · 10 comments
Closed

StreetComplete banned / Undo Feature was broken Jan 7 - Feb 9 #852

westnordost opened this issue Feb 9, 2018 · 10 comments

Comments

@westnordost
Copy link
Member

westnordost commented Feb 9, 2018

My version of StreetComplete is banned??

Jup, I disabled uploads for versions v3.3 to v3.6 and the v4.0 beta1 because it turned out that the undo feature was partly broken in these versions. Version 3.3 came out on January 7th.

To enable uploads again, just update.

Here is some more information on this:

What exactly did not work?

Technically, the undo feature consists of two parts: undoing an answer while it hasn't been uploaded yet, and undoing an answer that has already been uploaded to OpenStreetMap - a.k.a. reverting.
It was the reverting that was broken. In the app, it looked like it worked alright, but in reality, nothing was reverted. That it did not work, you could only see by that the seemingly undone quest did not pop up again on the map. This is also how the bug was found today (#849).
So, in a nutshell, if you always uploaded your answers manually after your survey and made your corrections "offline" (if any), you can ignore all this, all is fine.
If not (by default, answers are uploaded immediately) and you remember undoing things in the last month, you should check your OSM history for not-actually-undone-mistakes.

When is this fixed?

It is fixed now. In version 3.7 and version v4.0-beta2.

If you are here from F-Droid: Their repository takes up to one week to update to the latest version. But that's fine, you can still continue to solve quests offline and when the new version is out, upload everything. Or, you can also download the new APK from github.

How do I see my changes / How to correct this?

You see all the changes you made on https://www.openstreetmap.org/. Click on your name, then on "My Edits". There, you have an overview over all your changesets, ordered by date.
If that feels to unwieldy, you can also try https://osmcha.mapbox.com. This tool can also show your changes and does that in a very clearly arranged fashion. On Osmcha, click on "Filters" and scroll down to fill in your username in order to show only changes made by you.
Once you identified that there is a mistake, the easiest way to correct it would be to use the editor on the openstreetmap website, iD, to correct the information (click the Edit button on openstreetmap.org).

@westnordost westnordost changed the title Undo Feature was broken Jan 7 - Feb 9 StreetComplete banned / Undo Feature was broken Jan 7 - Feb 9 Feb 10, 2018
@rugk
Copy link
Contributor

rugk commented Feb 10, 2018

Or, you can also download the new APK from github.

But that does not allow you to upgrade the old versioon to a new one, as it has a different signature.

@lenod
Copy link

lenod commented Feb 11, 2018

Unfortunately, the build failed on fdroid, seemingly for a simple http timeout reason…
https://f-droid.org/wiki/page/de.westnordost.streetcomplete/lastbuild_307

@westnordost
Copy link
Member Author

westnordost commented Feb 11, 2018

Uhm, yeah, looks like it. I can download that jar without problem.

This will somewhat delay everything now. I think their build server does not automatically retry, one has to create a ticket and all that.

Edit: Reading through the F-Droid forum, it seems that the build server will automatically retry after some time. Let's see.

@westnordost
Copy link
Member Author

So, I asked in the F-Droid forum if after the failing build, any manual action for retrying is necessary or not, let's see.

@rugk
Copy link
Contributor

rugk commented Feb 12, 2018

link?

Edit: found it.

@rugk
Copy link
Contributor

rugk commented Feb 12, 2018

Answer is:

Yes. No action required.

@nebulon42
Copy link

Build succeeded: https://f-droid.org/wiki/page/de.westnordost.streetcomplete/lastbuild_307

@JeanFred
Copy link

Got the 3.7 upgrade this morning via F-Droid :)

@privatwolke
Copy link

I really appreciate the transparency with this issue! Thank you for your exemplary work! 👍

@westnordost
Copy link
Member Author

On Google Play, on Thursday there were still 6.8% on the affected versions. I expect the number will go down to near-zero until before the next update, so I will remove the alert message (and close this issue).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@JeanFred @privatwolke @nebulon42 @lenod @westnordost @rugk and others