Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not attack new user with request to register/login so early #1446

Merged

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Jun 27, 2019

During UX testing it turned out that starting is really confusing for an user actually new to OSM

She needed to (everything listed in full, as it is intended to solve a part of a larger problem)

  • install application
  • grant permissions (works great)
  • wait for quests to load (this is not obvious that it is necessary, Swipe/encouraging/information screens #178 exists with a good idea for solving this)
  • figure out app interface
  • figure out interface of the first quest (for bonus points - first one turned out to be opening hours quest, that maybe should be hidden for green users with <10 stars)
  • solved quest
  • immediately login window appeared
  • it was necessary to register, with entire form filling + ToS + mail confirmation drudgery
  • after registration app was stuck waiting for login, it was necessary to cancel this and request login again, login spinner initially refused to act (not sure is it user/phone error or an app bug)
  • now it was necessary to login

She told me that if she would be trying app on her own there would be no chance at all to pass through all this hoops at the very start.

All of that to solve first quest. I am pretty sure that delaying nag screen about registration would be a good idea as it would not harm more experienced users, they will make more than 7 edits and login a bit later. It would mean that edits by people who made six edits and less are lost, but they would probably be lost on going through registration process.

And it would help some newbie users that would be too confused by a current process, but would be OK with more gradual ramping up.

2020 EDIT: also some experienced mappers may be a bit confused how to login, but login is still possible through the settings menu and hopefully they will make some edits before getting confused.


Implementation itself is more suspect as current AnswersCounter is about interface only, in fact it is giving answer reduced by one as it is increased only after animation completes (so login window is triggered on 7th edit).

It can be solved by having separate unsynced and displayedUnsynced, ignoring disrepancy or not mixing displayed statistics and statistics infuencing UI behavior (I have some additional ideas for special handling for newbie mappers).


My work on this pull request and UX testing was sponsored by a NGI Zero Discovery grant

@matkoniecz matkoniecz changed the title do not attack new user with request to register/login do not attack new user with request to register/login so early Jun 27, 2019
@matkoniecz matkoniecz force-pushed the delay_registration_call branch from 5438c2f to 4e4d3f2 Compare June 27, 2019 14:58
@rugk
Copy link
Contributor

rugk commented Jun 27, 2019

If you do so, you should possibly re-work the UI a little to make it obvious to the user that everything is lost when they don't login? (So it is more obvious that it makes no sense to just solve quests and do not continue to login.)

@matkoniecz
Copy link
Member Author

It would change outcome only for people making less than 7 edits and it is already covered by

It would mean that edits by people who made six edits and less are lost, but they would probably be lost on going through registration process.

@westnordost
Copy link
Member

This is reasonable.

after registration app was stuck waiting for login, it was necessary to cancel this and request login again, login spinner initially refused to act (not sure is it user/phone error or an app bug)

...is worth investigating. If it is stuck, it means that the app is not called-back from the browser. What browser was she using?

@westnordost westnordost merged commit 41d2bad into streetcomplete:master Jun 27, 2019
@matkoniecz
Copy link
Member Author

What browser was she using?

Chrome, but she went through a bit chaotic switching between StreetComplete, Gmail, Chrome, went to desktop once or twice between that...

During registration OSM Website was also quite broken so I suspect that there may be something wrong with her phone/browser.

I plan on retesting path for user who goes to register from browser launched during authorization, including wonky OSM website.

@matkoniecz matkoniecz deleted the delay_registration_call branch June 27, 2019 21:42
@matkoniecz matkoniecz mentioned this pull request Jul 5, 2019
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 8, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 8, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 8, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 8, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
affected people not logged in, with low star cound and disable autosync
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 8, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
affected people not logged in, with low star count and disabled autosync
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 10, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
affected people not logged in, with low star count and disabled autosync
matkoniecz added a commit to matkoniecz/Zazolc that referenced this pull request Jul 10, 2019
fixes streetcomplete#1446 - upload button was not working for unlogged users with low star count
affected people not logged in, with low star count and disabled autosync
@westnordost westnordost mentioned this pull request Aug 25, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants