Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop asking for roof shape by default #3161

Merged
merged 7 commits into from
Aug 16, 2021

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Aug 14, 2021

correct answer is tricky, this quest type is flooding most areas, data is of minimal importance, in cities for many buildings it cannot be answered at all by survey from ground, typically answerable from aerial imagery, no important use of this data (even less after you skip entities not crediting OSM)

fixes #3155 as now only people really interested in roof mapping will enable it

For example: potential mappers were wasting enormous amount of effort on categorizing https://www.google.pl/maps/@50.1388172,19.9129097,3a,31.4y,232h,109.1t/data=!3m6!1e1!3m4!1shE0xPjaYZANvFQO1px9E_A!2e0!7i13312!8i6656 (roof style popular in that village)

screen01

When I map with this quest enabled I have niggling thought "WTF I am doing with my time".

I am tempted to propose the same (disabling by default) with building level quest, power pole material and backrest quest.

Obviously, quest should remain as anyone interested in this kind of data can enable roof shape quest and enjoy an excellent SC interface.

correct answer is tricky, this quest type is flooding most areas, data is of minimal importance, in cities for many buildings it cannot be answered at all by survey from ground, typically answerable from aerial imagery, no important use of this data (even less after you skip entities not crediting OSM)

fixes streetcomplete#3155 as now only people really interested in roof mapping will enable it
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when the roof shape quest is disabled by default, what we could remove is the "not asking for roof shape if it is not likely visible from below" because by enabling the quest, the user knows what he is doing.

@@ -497,6 +497,7 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards
<string name="enable_quest_confirmation_title">Enable this quest type?</string>
<string name="default_disabled_msg_go_inside">This quest type is disabled by default because you will likely have to enter the place to be able to answer a quest of this type.</string>
<string name="default_disabled_msg_go_inside_regional_warning">This quest type is disabled by default because it is not useful in some regions and you will likely have to enter the place to be able to answer a quest of this type.</string>
<string name="default_disabled_msg_tricky_3d_rendering">This quest type is disabled by default because it is time-consuming, correct answer is not always obvious and data is used only in 3D rendering.</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? I find it more important to mention that it would be more efficient in most cases to record this information from aerial imagery (=not with this app) than what the usages might be.

Suggested change
<string name="default_disabled_msg_tricky_3d_rendering">This quest type is disabled by default because it is time-consuming, correct answer is not always obvious and data is used only in 3D rendering.</string>
<string name="default_disabled_msg_tricky_3d_rendering">This quest type is disabled by default because the roof shapes are often not well visible from the street. This quest type is also quite time-consuming, while it is in most cases easier and more efficient to map this from aerial imagery at home.</string>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses the part that convinced me that it is a good idea (roof shapes not really matching to any selection), but maybe it is not needed to mention it...

Co-authored-by: Tobias Zwick <osm@westnordost.de>
@matkoniecz
Copy link
Member Author

New reasoning misses the part that convinced me that it is a good idea (roof shapes not really matching to any selection), but maybe it is not needed to mention it - user is warned already...

Though with new reasoning generic default_disabled_msg_tricky_3d_rendering should be changed as reasoning is not reusable anymore for other values.

@matkoniecz matkoniecz marked this pull request as draft August 14, 2021 13:43
roof shape no longer enabled by default, so only people really interested in roof shapes will enable it
so more false positives are OK to avoid some false negatives
@matkoniecz matkoniecz marked this pull request as ready for review August 15, 2021 12:33
@peternewman
Copy link
Collaborator

typically answerable from aerial imagery

I've not tried doing this from aerial imagery, but when I've been looking at other stuff via imagery, I'd be surprised if you could accurately differentiate a lot of these using aerial imagery, especially e.g. flat versus sloped or say the various Mansard styles versus a normal pitched roof.

I am tempted to propose the same (disabling by default) with building level quest, power pole material and backrest quest.

At least the last one has a possible medically related benefit (although whether anyone is actually searching based on that is debatable).

Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
@westnordost westnordost merged commit 1f6fb6c into streetcomplete:master Aug 16, 2021
@matkoniecz matkoniecz deleted the kill_roof branch August 19, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't ask for roof shapes that likely involve guessing
3 participants