Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic calming, fixes #2742 #3380

Merged
merged 13 commits into from
Oct 15, 2021

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Oct 14, 2021

fixes #2742

screen08

Still not ideal, but I think that it is a good enough - https://taginfo.openstreetmap.org/tags/traffic_calming=yes has 14k elements, so not worth as extreme effort on tweaking as surface that covers very big part of all edits made with SC.

@matkoniecz
Copy link
Member Author

If bump is bad then alternative photo is https://commons.wikimedia.org/wiki/File%3AGometz%2Dla%2DVille%5Fle%5F1er%5Fmai%5F2012%5F%2D%5F13%2Ejpg

If anyone can take/find a better photo: I would be happy to use them!

app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@andrewharvey
Copy link
Contributor

Text is a welcome addition.

@matkoniecz
Copy link
Member Author

Looking at patch once again - I need to get an icon. Maybe I am capable of stealing bump sign from some traffic sign?

@matkoniecz matkoniecz marked this pull request as draft October 15, 2021 07:22
@matkoniecz
Copy link
Member Author

matkoniecz commented Oct 15, 2021

And I "made" an icon.

#3380 (comment) (bump vs hump) remains as a potential issue

I would be really happy to replace island with a less busy photo.

screen02

@matkoniecz matkoniecz marked this pull request as ready for review October 15, 2021 13:02
@westnordost
Copy link
Member

westnordost commented Oct 15, 2021

Alternatively a funny icon would be the sad looking blue car from this icon

but without without the forbidden-sign and maybe rotated so that one wheel above what looks like half an oval (the bump) or something

@westnordost
Copy link
Member

westnordost commented Oct 15, 2021

The descriptions and pictures are very good!

@matkoniecz
Copy link
Member Author

matkoniecz commented Oct 15, 2021

On icon: very good idea, I may try (after next MapLibre research session) - but no promises about success. This bump took quite a lot of time for me :)

I also thought about snail/turtle but thought that it may be too cryptic.

@westnordost
Copy link
Member

Mh that's also a nice idea. Let me do the icon.

@westnordost
Copy link
Member

So how about this? I agree that the snail may be too cryptic.

speedbumps

@matkoniecz
Copy link
Member Author

So how about this?

I like it! My bump was passable but quite empty/bare and not really clear.

Ironically, traffic calming is quite unlikely to apply in this way (big bump for just one side of vehicle) - at least none of depicted. But for icon it works nicely.

But maybe this icon would fit even better for smoothness quest that AFAIK is also planned?

@westnordost
Copy link
Member

There's already an icon for smoothness.

Added the SVG

@westnordost westnordost added the hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event label Oct 15, 2021
@matkoniecz
Copy link
Member Author

matkoniecz commented Oct 15, 2021

Added the SVG

Used svg. Should I remove bump drawable/svg or should it be kept just in case that we will have bump-specific quest?

@westnordost
Copy link
Member

You can remove it

@westnordost
Copy link
Member

One important point to clarify before merge

Is maybe traffic_calming=yes used on other map features as a property? If yes, those things need to be excluded juts like you did for barrier=yes.

@matkoniecz
Copy link
Member Author

It should not happen. It can be with highway=crossing, but then it would traffic_calming=table

https://wiki.openstreetmap.org/wiki/Key:traffic_calming is not indicating combinations, https://taginfo.openstreetmap.org/tags/traffic_calming=yes#combinationss indicates that it is sometimes apparently used on waus but I only nodes are taken here

should be solvable from significant distance
rare so more interesting
@westnordost westnordost merged commit a60298c into streetcomplete:master Oct 15, 2021
@matkoniecz matkoniecz deleted the traffic_calming branch October 15, 2021 20:59
@matkoniecz
Copy link
Member Author

I made one more text change for cushions: a9ed1ac

screen12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What sort of traffic calming is here? (for nodes, ways, areas tagged traffic_calming=yes)
5 participants