Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor adjustment to setting building properties #3390

Merged
merged 2 commits into from
Oct 16, 2021
Merged

minor adjustment to setting building properties #3390

merged 2 commits into from
Oct 16, 2021

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Oct 16, 2021 •
edited
Loading

fixes #3386

Not commiting directly as I am still unsure is it worth extra complexity

@westnordost
Copy link
Member

westnordost commented Oct 16, 2021 •
edited
Loading

I don't get it. Is disused considered to be synonymous to abandoned? Do you have a link to the wiki that explains this? Why would disused be mutually exclusive with abandoned?

@peternewman
Copy link
Collaborator

Why would disused be mutually exclusive with abandoned?

They're different lifecycle states:
https://wiki.openstreetmap.org/wiki/Lifecycle_prefix#Stages_of_decay

You can't be unconscious and dead at the same time.

@matkoniecz
Copy link
Member Author

Why would disused be mutually exclusive with abandoned?

All abandoned features are also disused, so it is duplication at best. Very strict and literal reading of https://wiki.openstreetmap.org/wiki/Lifecycle_prefix#Stages_of_decay would consider disused=yes to be not including deep damage state, where object qualifies for abandoned=yes

@westnordost westnordost merged commit 2669cc2 into streetcomplete:master Oct 16, 2021
@matkoniecz
Copy link
Member Author

You can't be unconscious and dead at the same time.

Though something can be "not working" and "dead" at the same time, even if first is quite redundant given the second one.

@matkoniecz matkoniecz deleted the building branch October 17, 2021 05:33
@westnordost westnordost added the hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event label Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternewman peternewman peternewman left review comments

Assignees
No one assigned
Labels
hacktoberfest-accepted pull request that should be treated as eligible for Hacktoberfest event
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreetComplete tagging disused buildings as abandoned
3 participants
@matkoniecz @westnordost @peternewman