ask about barrier on intersection of barrier line and path [ready for review, again]

[matkoniecz]

fixes #3372

---

What would be the good quest question in this quest?

both

What is where path goes through a barrier?

What type of Stile/Gate/Gap is here?

What is at intersection of path and barrier?

are unfortunate and seem clunky to me.

---

Below are things that I implemented to my satisfaction (more or less) but I can be easily convinced to change that.

Is it a good idea to keep complex "path must actually cross barrier" logic? It was implemented already and will keep out some rare confusing cases.

Is it fine to duplicate this logic and helper function from crossing quest? If no where would be the best place to put it?

I plan to have both path quest and road quest here. For now just path is implemented, with shared code in a separate class.

(why separate quest for roads? Because it is typical to have gate for road and separately mapped path without a barrier along it, and separate quest logos and titles would be an useful help here)

[westnordost]

I'd very much prefer if there was no class hierarchy to share code. There are other ways to share code. (See e.g. KerbUtil)

Part or most of the filter logic could certainly go into a common utils file. The function that is called should have a clear general interface though. The primitives could move to SphericalEarthMath if they are primitive/general enough

[matkoniecz]

Some new ideas for the question:

What type of stile/gate/gap is here?

How does this path go through this barrier?

What is present where this barrier intersects the path?

sourced from Discord OSM Server

[westnordost]

Or

"What kind of barrier is here?"

It doesn't really matter for the user where the app sourced the information from that at this point, there is (very probably) some kind of barrier.

[matkoniecz]

It doesn't really matter for the user where the app sourced the information from that at this point, there is (very probably) some kind of barrier.

It is very useful when path and road close to each other have different barriers.

In other words I think that in this case this info can be easily made available and is likely to be useful so I want to make it available.

In related news I tried making icons and run into some issues described at https://graphicdesign.stackexchange.com/questions/154894/why-path-intersection-in-inkscape-is-not-fully-accurate (I hope that someone will reply there)

[matkoniecz]

I suspect that @westnordost is not entirely convinced about splitting this quest - but I would go in opposite direction, merge in here asking about barrier=yes located on paths and roads.

In meantime I tried making icons.

[westnordost]

What is the status of this PR, is it ready to review / merge? Any open questions?

[matkoniecz]

It is ready to merge (after solving minor conflict on language files) but

• not sure are you happy about icons (I am)
• you were dubious about splitting it into two quests

Why two quests?

It is very useful when path and road close to each other have different barriers.

I think that in this case this info can be easily made available and is likely to be useful so I want to make it available. I even thought about merging in question about barrier=yes into this quest for barrier=yes within highway= lines representing roads and paths.

[westnordost]

Regarding the picture, how about this

[matkoniecz]

By the way, I like the icons!

Thanks, nice to hear it (especially as it is likely the first real icon that I made on my own and actually liked)

[FloEdelmann]

Please see the three unresolved comments above:

1. ask about barrier on intersection of barrier line and path [ready for review, again] #3515 (comment) (the bottom part; unfortunately this is too large for a suggested change on GitHub)
2. ask about barrier on intersection of barrier line and path [ready for review, again] #3515 (comment)
3. ask about barrier on intersection of barrier line and path [ready for review, again] #3515 (comment)

After those are resolved, I'll approve this MR.

[matkoniecz]

#3515 (comment) (the bottom part; unfortunately this is too large for a suggested change on GitHub)

Hmm, I do not really find this additional bonus change as a better one.

Too many things happening at all for me.

#3515 (comment)

This should never happen as only nodes without tags are taken.

Though "Error: this should never happen, it is impossible" is not unusual. Not sure.

Even if it crashes, then crash and clear info that things went horribly wrong would be better than silent data corruption.

#3515 (comment)

Done.

[peternewman]

#3515 (comment)

This should never happen as only nodes without tags are taken.

Though "Error: this should never happen, it is impossible" is not unusual. Not sure.

Even if it crashes, then crash and clear info that things went horribly wrong would be better than silent data corruption.

Even if it's not currently, there's no reason that function couldn't be used for other barrier related quests which may have barrier set initially (or simply if you add barrier=yes), at which point it would break, so I'd say it's worth changing.

[matkoniecz]

Oh right, that can happen even now as it is now a generic code.

Though "Error: this should never happen, it is impossible" is not unusual.

demonstrated quite well

I would take down entire quest - that I implemented recently, nice one.

Thanks for spotting!

[westnordost]

Very clean implementation, thank you! Just two small comments: