Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make rejecting cancellation more clear #3576

Merged
merged 1 commit into from
Dec 11, 2021

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Dec 8, 2021

There is a "Discard input?" menu appearing after user fills answer, at least partially and tries to leave answer window.

It has options "cancel" and "discard" with "cancel" being not entirely clear - as user is cancelling filling of the quest. And "cancel cancelling" is tricky.

Situation is even worse in some translations where even the best found text is more confusing than English version.

see #3396 where it was discussed

screen02

Known negative effects: translation required again

I am aware of <string name="quest_generic_hasFeature_no">"No"</string> but in some languages this fields may require different translations.

There is a "Discard input?" menu appearing after user fills answer, at least partially and tries to leave answer window.

It has options "cancel" and "discard" with "cancel" being not entirely clear - as user is cancelling filling of the quest. And "cancel cancelling" is tricky.

Situation is even worse in some translations where even the best found text is more confusing than English version.

see streetcomplete#3396 where it was discussed
Copy link
Member

@smichel17 smichel17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Known negative effects: translation required again

I am aware of <string name="quest_generic_hasFeature_no">"No"</string> but in some languages this fields may require different translations.

I am not sure if this is a good practice, but one option would be to pre-seed the value of confirmation_discard_negative2 with whatever is translated for quest_generic_hasFeature_no, and then mark confirmation_discard_negative2 as fuzzy / needs-review in POEditor. I did something like this once when I was changing strings in Red Moon.

@matkoniecz
Copy link
Member Author

Sadly there was some accident with translations strings and nearly everything got marked as fuzzy - which is still not entirely repaired, what makes it less useful :/

@mnalis
Copy link
Member

mnalis commented Dec 9, 2021

Speaking with my translator hat on, I support that new answer which should be translated from scratch. Perhaps it should be bundled with some other new translation strings (like Smoothness quest #3257 ?) and translators be notified some time before so they can update it, then it should work well (for languages which are kept up-to-date at least). And beta release with new translation strings would be good idea before pushing an official one...

Stuff being marked as fuzzy is better than nothing, but for example I have several dozen translations I've myself marked as fuzzy as I'm not completely happy with them... I most probably won't see a new one pushed by SC there for quite some time, unless I'm specifically warned to go look for it.

@matkoniecz
Copy link
Member Author

matkoniecz commented Dec 9, 2021

And beta release with new translation strings would be good idea before pushing an official one...

That is happening already in every release cycle if I understand what you mean right.

Perhaps it should be bundled with some other new translation strings (like Smoothness quest #3257 ?)

In general such changes are merged and appearing in beta releases, in part to give time for translations.

@westnordost westnordost merged commit 65a02a6 into streetcomplete:master Dec 11, 2021
@matkoniecz matkoniecz deleted the cancel_cancel branch December 11, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants