house name and house number answer at once

[matkoniecz]

Add another answer "House number and a name" which gives a two field form, for house name and house number.

fixes #2540

Tested case where housenumber is entered, form switched to housename - it record just housename as it should

NOTE: PR code needs one filler string in unrelated quest to compile

[andrewharvey]

Awesome, any thoughts on how SC could help capture those housenames not captured by SC originally because the mapper could only enter the number?

[smichel17]

Currently: only solution is to wait for resurvey.

I can't think of anything which could be done for this specifically, but in general, either the layers feature or my proposed alternative, "bulk edit mode" (#2461 (comment)) would allow editing at times when a quest would not normally be shown.

[matkoniecz]

Awesome, any thoughts on how SC could help capture those housenames not captured by SC originally because the mapper could only enter the number?

This is likely not feasible to do as a quest. Asking for housenumber for all buildings with house name where someone answered with partial info instead of making note is not a good idea as vast majority has just housename. Unless in some regions it is safe to assume that building always has house number and house name is a possible addition.

[smichel17]

Typo

[peternewman]

Currently: only solution is to wait for resurvey.

I don't believe there is a resurvey and don't see any code for one either. But I can think of very few cases when a house number or name would change either.

I can't think of anything which could be done for this specifically, but in general, either the layers feature or my proposed alternative, "bulk edit mode" (#2461 (comment)) would allow editing at times when a quest would not normally be shown.

There is some potentially valid tagging for it:
https://wiki.openstreetmap.org/wiki/Tag:noname%3Dyes

But aside from asking for every house as others have said I can't think of a sensible way to filter it.

[peternewman]

Just an observation, this quest includes:
Housenumber
HouseNumber
HOUSENUMBER
House number

And similar for house name.

I appreciate the OSM key is addr:housenumber and the English is "House Number", but would it be worth being consistent and either using housenumber/HOUSENUMBER/Housenumber throughout, or treating it as two words everywhere apart from when it's the actual OSM key (i.e. houseNumber/HOUSE_NUMBER/HouseNumber).

Likewise, but not as bad, for house name.

[matkoniecz]

@smichel17 @FloEdelmann @peternewman Thanks for reviews here and elsewhere!

[westnordost]

Alright, also review by me. A few things could be simplified. There is one UI issue I see (IMO).

[smichel17]

Looks good to me.

[FloEdelmann]

Looks good to me now. Thanks @matkoniecz for implementing the feedback!