Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for name, opening hours, wheelcair access for some healthcare tags #3710

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Ask for name, opening hours, wheelcair access for some healthcare tags #3710

merged 2 commits into from
Feb 1, 2022

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented Feb 1, 2022

All of them are included in https://github.com/streetcomplete/StreetComplete/blob/master/app/src/main/assets/osmfeatures/default/de.json, so translations should be fine. I haven't checked other languages though.

@matkoniecz
Copy link
Member

Any reason why "sample_collection", "blood_donation", "physiotherapist", "podiatrist", are excluded from wheelchair quest?

I would skip "laboratory" - it can be used according to its definition to internal features not accessible at all (often healthcare=sample_collection are marked as laboratories - or to be more specific there was not even a tagging for them before https://wiki.openstreetmap.org/wiki/Proposed_features/healthcare%3Dsample_collection ).

healthcare=laboratory + sample collection=yes indicates that it is publicly accessible but it is barely used.

Hmmmm. Maybe quest for healthcare=laboratory which would add sample collection=yes or sample collection=no or retag to healthcare=sample_collection would be a good idea? (disclaimer: I invented this tags and wrote most of https://wiki.openstreetmap.org/wiki/Proposed_features/healthcare%3Dsample_collection )

@FloEdelmann
Copy link
Member Author

For physiotherapist and podiatrist, it might be difficult to determine if they can actually treat wheelchair patients.

For sample_collection and blood_donation, there is no real reason. I'll add them.

often healthcare=sample_collection are marked as laboratories

That's why I added them. If you think it will be difficult to determine there, I'll remove it though.

Maybe quest for healthcare=laboratory which would add sample collection=yes or sample collection=no or retag to healthcare=sample_collection would be a good idea?

If they can be "internal features not accessible at all", then it's probably not a good idea. Additionally, I think that determining "yes" is probably mostly easy, but "no" will often be much harder.

@matkoniecz
Copy link
Member

Looks great to me, though I have not tested code in action so far.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good addition, thank you!

@westnordost westnordost merged commit 6d24818 into streetcomplete:master Feb 1, 2022
@FloEdelmann FloEdelmann deleted the opening-hours branch February 1, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants