Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak amount of answer history considered in recently-used values #3726

Merged
merged 1 commit into from
Feb 6, 2022
Merged

Tweak amount of answer history considered in recently-used values #3726

merged 1 commit into from
Feb 6, 2022

Conversation

smichel17
Copy link
Member

  • Building levels historyCount: 30 → 15
  • Building type historyCount: 30 → 50

Fixes #3593

@smichel17
Tweak amount of answer history considered.
323de75 
The historyCount value of 30 was picked somewhat arbitrarily, based on a
guess of how much you'd have to consider to have a different result than
just showing the latest 6 values.

For the building levels quest, this was too much, since only 5 values
were shown. When moving between areas with different building heights,
it forced you to re-enter values too many times. Counting only 15 values
should fix this. But we should keep an eye out to make sure we didn't
over-shoot and get rid of any benefit of tracking a larger stretch of
history.

For the building type quest, 30 didn't feel like enough, since the
distribution of answers is different; an item would keep dropping off
the end of the list a few answers before I wanted to use it again.
Bumping it up to 50 fixed that. Testing in a mixed area, it worked
great. But there's a risk that it will cause the same problem as in the
building levels quest; in that case, increasing the `first` value to 2
or 3 is a good next thing to try.
@smichel17 smichel17 merged commit a24bd9e into streetcomplete:master Feb 6, 2022
@smichel17 smichel17 deleted the favs-history-length branch February 6, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building levels list removes new entries too quickly
1 participant
@smichel17