Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycleway overlay: Differentiate bicycle access on pedestrian roads #6020

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

westnordost
Copy link
Member

@westnordost westnordost commented Nov 22, 2024

fixes #6016

Changes:

  • pedestrian roads are now colored like footways: black by default, aquamarine when bicycles are allowed, cyan when also designated to bicycles
  • added other-answer options (only displayed for pedestrian streets) to switch between these.
  • Cannot select bicycle road for pedestrian streets
  • current bicycles-on-pedestrian-road situation is displayed in form UI
  • also for bicycle roads: the displayed sign is not modal anymore, i.e. can specify left-and-right-situation, too

@SebSeb11
Copy link

My findings for d3a6c2b

Pavement mode:

Cycleway mode:

  • three dot menu entries:
    "No explicit sign about cycling here" + "A sign allows cycling here" + "Designated for cycling here"
    ... are accessible when selecting residential road, bicycle boulevard, secondary road, motorway. Not needed because of the normal cycleway UI.
  • when adding protected bicycle lanes to both sides of a pedestrian road, colored lines appear e.g. for Weserpromenade, how it should be. But, it is only shown on one side for my example way. I think it's because of an overlaying area tagged as pedestrian zone.

@westnordost
Copy link
Member Author

Cool, thanks for testing it!

I don't understand your comment about "pavement mode". Could you add a screenshot or something?

three dot menu entries: [...]

Oh! Weird, I thought I tested that. Will fix before merge.

when adding protected bicycle lanes to both sides of a pedestrian road, colored lines appear e.g. for Weserpromenade, how it should be. But, it is only shown on one side for my example way. I think it's because of an overlaying area tagged as pedestrian zone.

Yes, overlaying things will overlay, ¯_(ツ)_/¯. However, pedestrian areas shouldn't actually be highlighted at all in this overlay and thus also not appear in front of these things. I will have a look.

@SebSeb11
Copy link

SebSeb11 commented Nov 23, 2024

Pedestrian street could be made visible like foot paths:

@westnordost
Copy link
Member Author

Ah I see, well, makes sense, but I'll implement that separately.

@SebSeb11
Copy link

One more litte remark. Maybe it is supposed to be, but:
The "sign allows cycling" or "designated for cycling" option disappears from three dot menu if it is the current status of the way. "No explicit sign" option is always shown.

That's it. Thank you for your work :)

@westnordost
Copy link
Member Author

Oh, yes, that's another bug

@westnordost westnordost merged commit 7e2fd27 into master Nov 25, 2024
@FloEdelmann FloEdelmann deleted the bicycle_ok_on_pedestrian_streets branch November 25, 2024 16:16
@westnordost
Copy link
Member Author

Thanks for the review, @FloEdelmann !

@FloEdelmann
Copy link
Member

You're welcome 🙂

For reference, the suggestions were applied in 6dbea87.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

visibility of bicycle=yes at pedestrian zones
3 participants