Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Update launcher brand icons #2345

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Conversation

minktusk
Copy link
Contributor

@minktusk minktusk commented Jun 22, 2024

PR Details

Replace old brand icons for new brand icons

Related Issue

Any, just some icons change

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk
Copy link
Collaborator

Thanks, It looks like this is your first PR. I have a question, where did you get the social icons from? Unfortunately, some look to be of lesser quality than the old ones

@minktusk
Copy link
Contributor Author

minktusk commented Jun 22, 2024

Thank you for reply, well, I get them from the official brand pages, then resize it

@VaclavElias
Copy link
Contributor

Could we use SVG, if XAML supports that?

@Doprez
Copy link
Contributor

Doprez commented Jun 23, 2024

https://uxwing.com/x-social-media-round-icon/
Im not sure if these are better for quality @Jklawreszuk but it seems like the licenses should be good.

They also provide SVG if you want to try that route and see how they are.

@Jklawreszuk
Copy link
Collaborator

@minktusk Oh, I see. Like @Doprez suggested, try to find SVG images and try to export them into png files (i.e using Inkscape) - this way you can be sure that the images will be rendered correctly :)
Don't forget to add the license to these logos in the https://github.com/stride3d/stride/blob/master/LICENSE.md file 😊

@Jklawreszuk
Copy link
Collaborator

If WPF supports SVG file format then you can also replace pngs directly if you wish so. It shouldn't cause much lag

@minktusk
Copy link
Contributor Author

minktusk commented Jun 23, 2024

Thanks, I will try change the icons to SVG and see if it works properly!

@minktusk
Copy link
Contributor Author

Sorry for taking so long to update this pull request. I wasn't able to make it run SVG files. Honestly, I don't know if it's because XAML doesn't have support for it, or because I just don't know how to use XAML with SVG. So instead of using SVG, I just export them all to PNG using Inkscape ( Recommended by @Jklawreszuk ).

PS: I also changed all mentions in the code from Twitter to XTwitter!

@VaclavElias
Copy link
Contributor

I found this (also as NuGet) but have no experience with it, also not sure if there are other alternatives. Probably, we should keep whatever has less gears and is easier to maintain?

https://elinamllc.github.io/SharpVectors/

@Eideren
Copy link
Collaborator

Eideren commented Jul 3, 2024

Not sure about svg but xaml supports embedded vectors, see https://github.com/stride3d/stride/blob/master/sources/editor/Stride.Assets.Presentation/View/ImageDictionary.xaml
There's a couple of tools built to make the conversion, lookup svg to xaml
In any case, having them as bitmaps is fine too, I'll merge this one with the rest this week end

@Eideren
Copy link
Collaborator

Eideren commented Jul 6, 2024

Thanks !

@Eideren Eideren merged commit e41fb06 into stride3d:master Jul 6, 2024
2 checks passed
@Eideren Eideren changed the title Update launcher brand icons style: Update launcher brand icons Jul 6, 2024
@Eideren Eideren added the area-Launcher Stride Launcher label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Launcher Stride Launcher
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants